Skip to content

Migrate dd-trace-core groovy files to java part 14 - #12332

Open
jpbempel wants to merge 3 commits into
masterfrom
jpbempel/g2j-core-pt14
Open

Migrate dd-trace-core groovy files to java part 14#12332
jpbempel wants to merge 3 commits into
masterfrom
jpbempel/g2j-core-pt14

Conversation

@jpbempel

Copy link
Copy Markdown
Member

What Does This Do

we migrate 3 tests from traceAgentTest module

Motivation

this is part of the effort to migrate groovy tests to Java/JUnit
part1: #11053
part2: #11062
part3: #11085
part4: #11146
part5: #11217
part6: #11362
part7: #11374
part8: #11437
part9: #11488
part10: #11543
part11: #11566
part12: #11619
part13: #12253

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

we migrate 3 tests from traceAgentTest module
@jpbempel
jpbempel requested review from a team as code owners August 28, 2026 12:38
@jpbempel
jpbempel requested review from AlexeyKuznetsov-DD and mcculls and removed request for a team August 28, 2026 12:38
@dd-octo-sts

dd-octo-sts Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 41dae6b7d8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread dd-trace-core/src/traceAgentTest/java/DDApiIntegrationTest.java Outdated
Comment thread dd-trace-core/src/traceAgentTest/java/DataStreamsIntegrationTest.java Outdated

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: FAIL

After DDApiIntegrationTest runs locally, JUnit does not run the parent container cleanup. The Docker agent stays active.

Open Bits AI session

🤖 Datadog Autotest · Commit 41dae6b · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

Comment thread dd-trace-core/src/traceAgentTest/java/DDApiIntegrationTest.java Outdated
@datadog-datadog-prod-us1

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.02 s 14.05 s [-1.1%; +0.6%] (no difference)
startup:insecure-bank:tracing:Agent 12.86 s 13.06 s [-2.3%; -0.7%] (maybe better)
startup:petclinic:appsec:Agent 16.87 s 16.76 s [-0.3%; +1.7%] (no difference)
startup:petclinic:iast:Agent 16.95 s 16.94 s [-0.9%; +1.0%] (no difference)
startup:petclinic:profiling:Agent 16.79 s 16.83 s [-1.2%; +0.8%] (no difference)
startup:petclinic:sca:Agent 16.82 s 16.39 s [+1.7%; +3.5%] (significantly worse)
startup:petclinic:tracing:Agent 16.10 s 16.11 s [-0.8%; +0.7%] (no difference)

Commit: 784a1b96 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@jpbempel jpbempel added comp: testing Testing type: refactoring tag: no release notes Changes to exclude from release notes labels Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants