feat(redis-ha): expose ipFamilies/ipFamilyPolicy on headless and announce services - #421
Open
aqeelat wants to merge 1 commit into
Open
feat(redis-ha): expose ipFamilies/ipFamilyPolicy on headless and announce services#421aqeelat wants to merge 1 commit into
aqeelat wants to merge 1 commit into
Conversation
…unce services Signed-off-by: Abdullah Alaqeel <abdullah.t.aqeel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Exposes
ipFamilies/ipFamilyPolicyon the headless and announce Services, mirroring the existinghaproxy.service.*knobs. On dual-stack clusters operators are moving Services to IPv6-primary to preserve exhausted IPv4 ServiceCIDR space (context in #419); today only the haproxy Service can be configured this way. Also documentssentinel.{resolveHostnames,announceHostnames}as the recommended posture for dual-stack/IPv6-primary clusters.Which issue this PR fixes:
Special notes for your reviewer:
Announce Services intentionally inherit the same top-level values. Defaults (
""/[]) render nothing, so no behavior change for existing users. Note in-place family flips are rejected by admission (delete+recreate required), which is exactly why having this in values helps Helm/Argo own the recreate.Checklist