Skip to content

Change max_file_size_test TP_rate_per_channel to 4.75. - #505

Merged
xinyue-uoft merged 1 commit into
prep-release/fddaq-v5.7.0from
theo/ts_rate_fix
Sep 1, 2026
Merged

Change max_file_size_test TP_rate_per_channel to 4.75.#505
xinyue-uoft merged 1 commit into
prep-release/fddaq-v5.7.0from
theo/ts_rate_fix

Conversation

@xinyue-uoft

@xinyue-uoft xinyue-uoft commented Sep 1, 2026

Copy link
Copy Markdown

Description

DUNE-DAQ/datahandlinglibs#144 has adjusted TP_rate_per_channel logic to address issue DUNE-DAQ/datahandlinglibs#74. This has caused max_file_size_test to fail with an additional record file (7) instead of 6. In order to fix the test, base rate is reduced from 5 to 4.75.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Adjusted max_file_size_test passes.

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@xinyue-uoft
xinyue-uoft changed the base branch from develop to prep-release/fddaq-v5.7.0 September 1, 2026 12:40

@bieryAtFnal bieryAtFnal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The max_file_size_test now runs with no complaints.

@xinyue-uoft
xinyue-uoft merged commit 23f6bef into prep-release/fddaq-v5.7.0 Sep 1, 2026
5 of 6 checks passed
@xinyue-uoft
xinyue-uoft deleted the theo/ts_rate_fix branch September 1, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants