Change max_file_size_test TP_rate_per_channel to 4.75. - #505
Merged
Conversation
xinyue-uoft
changed the base branch from
develop
to
prep-release/fddaq-v5.7.0
September 1, 2026 12:40
bieryAtFnal
approved these changes
Sep 1, 2026
bieryAtFnal
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. The max_file_size_test now runs with no complaints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DUNE-DAQ/datahandlinglibs#144 has adjusted
TP_rate_per_channellogic to address issue DUNE-DAQ/datahandlinglibs#74. This has causedmax_file_size_testto fail with an additional record file (7) instead of 6. In order to fix the test, base rate is reduced from 5 to 4.75.Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Adjusted max_file_size_test passes.
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))