Feature: cad load store attribute interface

[holke]

Describe your changes here:

Fixes #2436

Depends on #2442.

The CAD geometries use internal cmesh macros from cmesh_types.h for attribute keys.

• added t8_geometry_cad::set_tree_geometries
• added t8_geometry_cad::set_tree_geometry_parameters
• added t8_geometry_cad::get_tree_geometries

The fix is to wrap the attribute functions in cad geometry specific setters and getters such that the attribute keys are hidden.

This has the additional advantage of:

• Cleaner code, since the manual attribute interface usage is quite ugly
• Less errors since users and developers do not need to bother with using the correct attribute keys.

All these boxes must be checked by the AUTHOR before requesting review:

• The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
• The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
• If the PR is related to an issue, make sure to link it.
• The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

• The reviewer executed the new code features at least once and checked the results manually.
• The code follows the t8code coding guidelines.
• New source/header files are properly added to the CMake files.
• The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
• README.md files are updated if necessary.
• All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

• The code is covered in an existing or new test case using Google Test.
• The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
• Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

• Should this use case be added to the github action?
• If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

• If a new directory with source files is added, it must be covered by the scripts/internal/find_all_source_files.sh to check the indentation of these files.
• If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

• The author added a BSD statement to doc/ (or already has one).

[holke]

@sandro-elsweijer i dont need a review from you, but would like to hear your opinion:

Is a static function in the t8_geometry_cad class a good place for this functionality?
I thought so since it is explicitly linked to how the cad geometry stores its data at the trees.
I decided against putting it into the cad handler, since the handler seemed to be independent of the geometry and how it stores its data.

[holke]

Update: The tests should pass, once #2442 is merged.

Thus, this can go into review.

[holke]

Update: The tests should pass, once #2442 is merged.

Thus, this can go into review.

Nope, there is still an error in the cad_hex evaluation. Working on it.