[for minor release] RSS configurable thresholds - #8520
Open
fstagni wants to merge 10 commits into
Open
Conversation
chrisburr
marked this pull request as draft
April 20, 2026 13:35
fstagni
force-pushed
the
rss_configurable_thresholds
branch
2 times, most recently
from
April 20, 2026 15:48
67caea8 to
5689ef1
Compare
fstagni
marked this pull request as ready for review
April 20, 2026 15:49
fstagni
force-pushed
the
rss_configurable_thresholds
branch
from
April 20, 2026 16:10
5689ef1 to
603dbf3
Compare
fstagni
force-pushed
the
rss_configurable_thresholds
branch
5 times, most recently
from
June 9, 2026 15:40
f45acb7 to
17e4b0e
Compare
Contributor
|
Contributor
|
I have put a comment in #8517 (comment) It would be nice if the thresholds can be set by absolute free space (eg. 0.1 TB) and by fraction (free/total, eg. 5%) I was trying to compare this PR and our code, but decided to comment now, before spending too much time and coming too late. |
1 task
fstagni
force-pushed
the
rss_configurable_thresholds
branch
from
July 6, 2026 08:30
17e4b0e to
28a1265
Compare
Contributor
Author
@iueda I have added the "fraction", as IUUC should be in the BelleDIRAC implementation. Please review. |
iueda
approved these changes
Sep 8, 2026
iueda
left a comment
iueda
left a comment
Contributor
There was a problem hiding this comment.
The code looks good (better than I was preparing).
Only minor suggestions on the comments and the tests.
There may be some remnants of my previous comments, which were in preparation and now obsolete (I tried to delete them, but somehow appears in the list of pending comments...)
iueda
reviewed
Sep 8, 2026
…ully configurable
- AlwaysBannedForSite2: tests domain-based matching specificity - AlwaysDegradedForResource: tests AlwaysDegraded policy type - SpecificFreeDiskSpace: tests per-policy arg overrides (Unit=GB, custom thresholds) and specificity dedup against generic FreeDiskSpace - PropagationForSite: tests Propagation policy type - PolicyActions sections: LogStatusAction and LogPolicyResultAction - Integration test cases for LogSE WriteAccess (Degraded via specific FreeDiskSpace), LogSE ReadAccess (Active via AlwaysActive), and Site with None status
…es and generic specificity deduplication - Configurations.py: POLICIESMETA now holds plain code-level defaults only; Operations() calls removed (CS is read at runtime by InfoGetter instead) - InfoGetter.getPoliciesThatApply: CS entries without policyType are skipped (they are command-args defaults sections, not policy definitions); non-reserved keys in a CS policy entry are collected as arg overrides, merged into the policy args with case-insensitive key normalisation and type casting - InfoGetter.postProcessingPolicyList: replaces the old FreeDiskSpaceMB/GB/TB hack with a generic rule — when multiple policies of the same policyType match, keep the most specific one (name-match presence > number of matchParams keys) - dirac.cfg: add SpecificFreeDiskSpace example (Unit=GB, Banned_threshold=15, Degraded_threshold falls back to default); fix missing closing brace in Policies - docs: note that command-args sections have no policyType and are not policy definitions - test: new Test_InfoGetter.py with 15 unit tests covering all the above
…d defaults FreeDiskSpaceCommand and DowntimeCommand no longer duplicate default values in .get() fallbacks — defaults live exclusively in POLICIESMETA and are guaranteed to be present in self.args by the time the command runs.
- StateMachine.setState: guard against self.state being None before
accessing self.states[self.state], preventing KeyError when the
machine transitions from a valid state to None and back.
- DowntimeCommand._prepareCommand: change key-existence checks to
value checks (if not self.args.get("name")) so that None values
from decisionParams defaults are also caught.
- Add unit tests for both fixes and a new StateMachine test suite.
- AlwaysBannedForSite2: tests domain-based matching specificity - SpecificFreeDiskSpace: tests per-policy arg overrides (Unit=GB, custom thresholds) and specificity dedup against generic FreeDiskSpace - PropagationForSite: tests Propagation policy type - PolicyActions sections: LogStatusAction and LogPolicyResultAction - Integration test case for LogSE WriteAccess (Error via FreeDiskSpace command when no occupancy data exists in test DB)
fstagni
force-pushed
the
rss_configurable_thresholds
branch
from
September 8, 2026 07:23
28a1265 to
0998326
Compare
Add Banned_fraction and Degraded_fraction config options to the FreeDiskSpace policy so SEs can be flagged based on the fraction of total free space in addition to absolute thresholds. - FreeDiskSpaceCommand: pass fractions through _prepareCommand, doNew, doCache - FreeDiskSpacePolicy: evaluate fraction thresholds alongside absolute ones - Configurations.py: add default fraction values (1% Banned, 5% Degraded) - Tests: update existing tests and add new fraction threshold test cases - Docs: update admin and developer guides with new config options
fstagni
force-pushed
the
rss_configurable_thresholds
branch
from
September 8, 2026 09:29
0998326 to
fd47b7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #8517
BEGINRELEASENOTES
*RSS
CHANGE: Added configurable thresholds and fractions for FreeDiskSpace policy evaluation
*Deployment
ENDRELEASENOTES