Skip to content

Added Test Case for Controllers.Graph/getGraph - #1803

Merged
david-yz-liu merged 3 commits into
Courseography:masterfrom
danielrafailov:add-getGraph-coverage
Sep 21, 2026
Merged

david-yz-liu merged 3 commits into
Courseography:masterfrom
danielrafailov:add-getGraph-coverage

Conversation

@danielrafailov

@danielrafailov danielrafailov commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Proposed Changes

Added a new test for the getGraphJSON action of the Controllers.graph module to verify that getGraphJSON returns an empty graph when there is no graph matching graphName in the database.

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests) X
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CI checks have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 35532799900

Coverage increased (+0.08%) to 59.895%

Details

  • Coverage increased (+0.08%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 4340
Covered Lines: 2650
Line Coverage: 61.06%
Relevant Branches: 991
Covered Branches: 543
Branch Coverage: 54.79%
Branches in Coverage %: Yes
Coverage Strength: 153.99 hits per line

💛 - Coveralls

@danielrafailov danielrafailov changed the title Add get graph coverage Added Test Case for Controllers.Graph/getGraph Sep 20, 2026

@david-yz-liu david-yz-liu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @danielrafailov!

@david-yz-liu
david-yz-liu merged commit f4f8d4d into Courseography:master Sep 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants