fix(graph): balance the Gravity slider across the full 0..400 range - #185
fix(graph): balance the Gravity slider across the full 0..400 range#185Coding-Dev-Tools wants to merge 13 commits into
Conversation
The Ledger Gravity slider (loose <-> tight) floored the loose end at setting 24 and used a 2x linear response mapping that saturated at 200, so a large part of the slider travel produced identical output. Drags through multiple intermediate events also ended at a different layout than a direct drag (path dependence). Engine (engraphis/dashboard_assets/engraphis-graph.js): galaxyBlackHoleGravitySetting and galaxyStellarGravitySetting now clamp 1:1 to 0..400 with no floors; preserveGalaxyPhaseOnResume is armed before inner render, outer render, and the synchronous physics reheat; schedulePhysicsUpdate arms the phase-preserve flag for its rAF reheat in galaxy mode so the post-burst frame does not re-run path-dependent contact corrections. Slider mapping (engraphis/dashboard_assets/ledger.js): graphSliderResponseValue maps the Gravity slider 1:1 (clamped identity) instead of the 2x linear gain that saturated at 200. Assets: cache version bumped to 20260831-galaxy-floor-fix-2 across dashboard_assets/index.html, ledger.js, both dashboard.js mirrors, and the classic/static index.html cache busters. Tests: tests/test_galaxy_gravity_floor.py pins loose >= tight * 1.5 across full travel; tests/test_galaxy_gravity_slider_no_dead_zone.py pins strict monotonicity of the engine constant across 0..400; tests/test_slider_response.py pins the shipped ledger.js mapping (401 unique strictly increasing effective values); tests/test_galaxy_gravity_slider.py updated for the full-travel contract; tests/e2e/graph-engine.spec.js adds burst path-independence and no-dead-zone sweep with canvas hash diffs; tests/test_graph_engine_asset.py version pins updated (file reflowed to CRLF by editor save; AST-verified no logic change beyond version pins).
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 413709b887
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8591fc386
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
engraphis/engraphis/dashboard_assets/engraphis-graph.js
Lines 10040 to 10043 in f16382f
Translate carrier systems instead of shrinking their orbits
When Galactic gravity changes, these coordinates scale every star and planet around the global anchor, so a 0→400 adjustment multiplies planet-to-star distances by the same roughly 0.6 ratio even though Local solar gravity was unchanged. This can push satellites into their stellar exclusion boundary and makes the next live physics step snap the local orbit back outward; move each system rigidly by the carrier's scaled displacement instead of scaling every member independently.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2003d73ea8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03eae5d985
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…tion layouts Communities and radial multiplied their centering forces by the normalized mass multiplier, but the default compact/original branch and the constellation branch derived x/y strengths solely from gravity, so the Black hole mass slider was inert in those modes (PR #185 thread 3902779917). Adds a d3-stubbed regression test pinning the 4.4x response at the clamp ceiling in both layouts.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 similar comment
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
408af09 to
c17e547
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
c17e547 to
5b91700
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Reconcile the slider branch with main's reviewed spacetime implementation: non-Galaxy D3 force wiring (full-range multipliers, damping->velocityDecay interpolation, mass-multiplied centering in every preset) and the tests/test_graph_engine_asset.py suite come from main; the Galaxy physics iteration (0..400 range contracts, coalesced contact-correction, zero-floor gravity) and the floor-test contraction rationale stay on this branch. Both branch-unique regression tests are preserved in the merged suite: test_black_hole_mass_reaches_centering_forces_in_every_non_galaxy_layout and test_slider_burst_reasserts_contact_invariant_when_galaxy_is_frozen. test_graph_engine_asset: 238 pass; slider/floor/every suites green; ruff, commercial manifest, and CSP asset gates pass.
5b91700 to
f17e36c
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
Summary
The Ledger Gravity slider (loose <-> tight) had three compounding defects:
Changes
Engine (engraphis-graph.js)
Slider mapping (ledger.js)
Assets
Tests
Verification