Skip to content

West-Midlands | 26-ITP-May | Maryam Janjua | Sprint 1 | Form Controls - #1414

Open
maryam-devio wants to merge 7 commits into
CodeYourFuture:mainfrom
maryam-devio:feature/form-controls
Open

West-Midlands | 26-ITP-May | Maryam Janjua | Sprint 1 | Form Controls#1414
maryam-devio wants to merge 7 commits into
CodeYourFuture:mainfrom
maryam-devio:feature/form-controls

Conversation

@maryam-devio

@maryam-devio maryam-devio commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Task ID: CYF-1004

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • I created a semantic HTML form that meets the task requirements.
  • All form inputs have associated labels and validation for required fields.
  • All the forms validate customer name, email, T-shirt colour, and T-shirt size.
  • I used radio buttons for predefined colour and size options.
  • I tested the form in the browser to ensure validation works correctly.
  • The HTML was validated with no errors or warnings.
  • The Lighthouse Accessibility score is 100.
  • I made regular commits while developing the solution.

@netlify

netlify Bot commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit e4c0b14
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6aaad288b166e50008234d69
😎 Deploy Preview https://deploy-preview-1414--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 84 (🔴 down 2 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@maryam-devio maryam-devio added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@jayshreehajgude2012 jayshreehajgude2012 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 5, 2026
jayshreehajgude2012
jayshreehajgude2012 reviewed Jun 5, 2026
View reviewed changes

@jayshreehajgude2012 jayshreehajgude2012 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check opening and closing tags.
validation used.
Try to add autocomplete property.
Provide default selection for options.

Comment thread Form-Controls/index.html
this will also help you fill in your PR message later-->
<!--Customer Name-->
<label for="name">Name</label>
<input

@jayshreehajgude2012 jayshreehajgude2012 Jun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation done

Comment thread Form-Controls/index.html
required pattern=".*\S.*\S.*"
/>
<!--Customer Email-->
<label for="email">Email</label>

@jayshreehajgude2012 jayshreehajgude2012 Jun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct input type used and validation done

Comment thread Form-Controls/index.html

<!DOCTYPE html>
<html lang="en">
<head>

@jayshreehajgude2012 jayshreehajgude2012 Jun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mismatch tags

Comment thread Form-Controls/index.html
@@ -13,15 +20,54 @@ <h1>Product Pick</h1>
</header>

@jayshreehajgude2012 jayshreehajgude2012 Jun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

body tag missing

Comment thread Form-Controls/index.html
type="text"
id="name"
name="name"
required pattern=".*\S.*\S.*"

@jayshreehajgude2012 jayshreehajgude2012 Jun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you provide simple validation pattern for the same.

Comment thread Form-Controls/index.html
/>
<fieldset>
<!--Select T-shirt colour-->
<legend>Choose T-shirt Colour</legend>

@jayshreehajgude2012 jayshreehajgude2012 Jun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provide default selection

Comment thread Form-Controls/index.html
<fieldset>
<!--Select T-shirt colour-->
<legend>Choose T-shirt Colour</legend>
<input type="radio" id="purple" name="colour" value="purple" required>

@jayshreehajgude2012 jayshreehajgude2012 Jun 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide default selection

@jayshreehajgude2012 jayshreehajgude2012 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jun 5, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@maryam-devio

maryam-devio commented Jun 7, 2026

Copy link
Copy Markdown
Author

Thank you for the feedback. I added autocomplete attributes, added default selections for colour and size, and rechecked the HTML tags.

@maryam-devio maryam-devio added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 8, 2026
@Poonam-raj Poonam-raj added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 9, 2026
@Poonam-raj

Poonam-raj commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Looks accurately fixed!

@maryam-devio maryam-devio mentioned this pull request Jun 11, 2026
Open
@illicitonion

illicitonion commented Aug 24, 2026

Copy link
Copy Markdown
Member

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

@maryam-devio

maryam-devio commented Sep 16, 2026

Copy link
Copy Markdown
Author

Hi, I deferred from the May ITP and I am now continuing my coursework. I have resumed working on this task and pushed my latest changes to the feature/form-controls branch. Could this PR please be reopened? Thank you!

@maryam-devio

maryam-devio commented Sep 16, 2026

Copy link
Copy Markdown
Author

Closing PR because the May ITP run has finished. Feel free to re-open if you're still working on it.

Hi, I deferred from the May ITP and I am now continuing my coursework. I have resumed working on this task and pushed my latest changes to the feature/form-controls branch. Could this PR please be reopened? Thank you!

@Poonam-raj Poonam-raj reopened this Sep 16, 2026
@github-actions

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jayshreehajgude2012 jayshreehajgude2012 jayshreehajgude2012 left review comments
Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maryam-devio @Poonam-raj @illicitonion @jayshreehajgude2012