Skip to content

Fixed disconnected oven for crafting - #88347

Open
LightCaptain wants to merge 10 commits into
CleverRaven:masterfrom
LightCaptain:fix_disconnected_oven_for_recipes
Open

Fixed disconnected oven for crafting#88347
LightCaptain wants to merge 10 commits into
CleverRaven:masterfrom
LightCaptain:fix_disconnected_oven_for_recipes

Conversation

@LightCaptain

@LightCaptain LightCaptain commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Features "Fixed disconnected oven for crafting"

Purpose of change

While playtesting to try out new recipes, i discovered that the "disconnected oven" item couldn't be used as a tool in crafting, mainly because it wouldn't use charges from a powergrid. Despite this, the player could still use it's oven quality and the stovetop (which still takes charges from the power grid) to craft what they needed.

This needs to be changed because:

  • It doesn't make any sense for food that needs to be baked (pizza, cakes, bread, etc) to be using the stovetop instead of the oven's interior when it has the electrical power to do so.
  • With some new alternate recipes being added, they'll only take the oven's interior and/or the microwave as it's heat source, since they have switch off timers.

Further changes
The "disconnected oven" string shown in the tool section of crafting recipes that needs heat sources didn't make sense either and the way i went about solving the issue. So these needed some more polish.

Describe the solution

Give the disconnected oven item a "tool_ammo" that uses "battery" charges, this alone will let the oven appliance use the powergrid, which in turn will allow this to provide "disconnected oven" as a tool in crafting recipes.

Further solution
Create a fake appliance item (pseudo) for the oven and move all charged_qualities and tool_ammo of "disconnected oven" to the newly created item.
(I would've used "power_draw" and not have "charges_per_use" for the pseudo item, but this had to be undone to make charged_qualities to only be accessible to the player while the oven is powered by it's grid).
Left the value of "charges_per_use" at 25, as it doesn't seem to consume power from the grid, like the heat source does.

Along with it, i updated the heat source and appliance to use the pseudo oven instead of the disconnected one, so that it shows up as "oven" in the crafting menu

Describe alternatives you've considered

Leaving the oven how it is for crafting recipes and letting other contributors re-discover this anomaly.

Testing

  1. Spawn a car battery and a disconnected oven.
  2. Place them as appliances in construction and connect the car battery to the oven.
  3. Check that the oven has power from the battery.
  4. Open the crafting menu and select any recipe that uses "heat source", such as cooked meat or pizza.
  5. Expand their crafting details and check if "oven" is highlighted green or has more than 0 charges for what it requires (if it does either of these, then the test is successful).

Further tests

  1. Repeat step 1 to 3 as seen above.
  2. Open the crafting menu and select any recipe that uses "heat source" and needs "oven cooking" quality, such as "baked potato".
  3. Expand their crafting details and check that "oven" and "oven cooking of 1" are highlighted green.
  4. "Disconnect power connections" to oven.
  5. Again check crafting details if they're still highlighted green (if not then test is successful).
  6. "Take down appliance", that being the oven.
  7. Once more check crafting details if "oven" tool or "oven cooking" quality are highlighted green (if not then all tests are successful).

Additional context

powergrid used in testing the changes
image

After the changes
image
image

@github-actions github-actions Bot added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Appliance/Power Grid Anything to do with appliances and power grid labels Aug 16, 2026
@LightCaptain LightCaptain changed the title Fix disconnected oven for crafting Fixed disconnected oven for crafting Aug 16, 2026
@github-actions github-actions Bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 16, 2026

@Fris0uman Fris0uman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong approach, the disconnected oven has no power source therefore it should just not have thhose qualities. Adding batteries to it doesn't make sense.
The temper property should be added to the vehicle part as a pseudo tool if it actually make sense

EDIT: my bad the vehicle part currently gets its qualities from the item definition

Comment thread data/json/items/appliances.json Outdated
Comment thread data/json/items/appliances.json Outdated
Comment thread data/json/items/appliances.json Outdated
@Fris0uman
Fris0uman dismissed their stale review August 19, 2026 08:28

the vehicle part oven gets its qualities from the item definition

@LightCaptain LightCaptain left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What value should i set "charges_per_use" to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants