[pacdaemon]

Citrine Python PR

Description

Ticket: PNE-9739

The SDK raises ValueError while deserializing an ingestion status whose error_type it doesn't know, so the server's error message never reaches the user. IngestionErrorType was last synced with TblSvc in 2024 and is missing 11 of the server's 32 values. This PR adds them, including mixed_amount_and_ingredient from platform-backend#6689 (merged). The SDK enum now matches the server's IngestionErrorType and ingestion-openapi.yaml.

Each sync has appended its new members after the existing ones, in the server's declaration order. The new members follow that rule. Version bumped 5.2.0 → 5.2.1.

Testing

A new parametrized test builds an IngestionStatus from each of the 11 wire values. All 11 cases fail with ValueError on main and pass with this change. The full suite passes at 100% coverage, and flake8 is clean.

PR Type:

• Breaking change (fix or feature that would cause existing functionality to change)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Maintenance (non-breaking change to assist developers)

Adherence to team decisions

• I have added tests for 100% coverage
• I have written Numpy-style docstrings for every method and class.
• I have communicated the downstream consequences of the PR to others.
• I have bumped the version in __version__.py

🤖 Generated with Claude Code

[anoto-moniz]

This is an API break. Given the precedent that's been set previously, we don't need to make it a major version bump, but it should be a minor one. Additionally, please communicate this change to the customer team.

[pacdaemon]

I just updated the minor as suggested, however this is not an API break change, code wrote with 5.2.0 will work here. This will prevent an ingestion to crash when one of the errors synced here occurs. It could be good for customer to know that now it will not crash under those errors. Btw, this is a PR stack, if you have a few mins and you want to take a look at #1071, that last piece will allow the sdk to be more forgiveness with missing mappings.

[anoto-moniz]

API break was the wrong term. It's a breaking behavior change as they can no longer handle these errors by catching a ValueErrror, and the follow-on PR will mean no unknown types can be caught that way. So someone upgrading may need to change their scripts.

Regardless, yes, I'll take a look at the follow-on, too.

[anoto-moniz]

Thanks for giving the customer team a heads up!