elrs-bind: store 20 bind phrases and scroll the history list - #1
Open
raphaelhunziker1202-stack wants to merge 1 commit into
Open
Conversation
raphaelhunziker1202-stack
force-pushed
the
bindphrase-history-scroll
branch
from
August 26, 2026 15:47
57f58e2 to
ab383d1
Compare
raphaelhunziker1202-stack
force-pushed
the
bindphrase-history-scroll
branch
from
August 26, 2026 15:54
ab383d1 to
f0de0bd
Compare
The history was capped at 5 entries, and the cap was on the stored data rather than the display: adding a sixth phrase silently dropped the oldest one from history.txt. Anyone managing a larger fleet loses phrases that are still in use and has to retype them. Show the history through a scrolling window of History.PAGE (5) rows so the on-screen footprint no longer depends on how much is stored, which is what forced the low cap in the first place. With that decoupled, raise the stored limit to 20. Up/Down buttons move the window a page at a time and are only shown when the history is longer than one page. A label shows the current position. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
raphaelhunziker1202-stack
force-pushed
the
bindphrase-history-scroll
branch
from
August 26, 2026 15:56
f0de0bd to
b7b5a97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bind phrase history is capped at 5 entries, and the cap is on the stored data rather than the display:
Adding a sixth phrase silently drops the oldest one from
history.txt. Anyone running more than five aircraft loses phrases that are still in use and has to type them again.Change
History.PAGE = 5— the number of rows actually rendered. The on-screen footprint no longer depends on how much is stored, which is what made the low cap necessary in the first place.History.MAX5 → 50 (stored entries)histOffsetscrolls a window over the list;history_text/history_press/history_removeresolve through it1-5 / 50history_clampOffset()keeps the window in bounds after a deleteHistory.load()already reads64 * History.MAXbytes, which covers the new limit (bind phrases are capped at 52 characters, so 50 x 53 = 2650 < 3200).No change to the row layout, the X delete button, or any CRSF handling.
Based on the
bindphrasebranch since it builds on the elrs-bind tool from ExpressLRS#10.Testing: written against the LVGL patterns already used in this repo (callback
text/visible/active). Happy to adjust the nav row placement or button labels.🤖 Generated with Claude Code