fix: accept unset Loom import options from existing clients - #2335
Merged
Merged
Conversation
richiemcilroy
marked this pull request as ready for review
September 22, 2026 21:37
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nullfor the optional owner and Space fields on the Loom import API, so installed CLI and MCP versions work after a web deployment.Why
Existing CLI and MCP clients serialize absent options as JSON
null. The API schema rejected that payload with HTTP 400 before the import handler ran. The handler already treats null values as unsupplied options.Validation
git diff --checkpassed.cargo fmt --allandcargo check -p cappassed for the CLI change. Its focused Rust test could not complete because the isolated worktree ran out of disk space during compilation.distartifacts were absent; CI will run in its normal environment.No production import was attempted. The server change requires web deployment; it does not require an installed CLI update.
The PR appears safe to merge with no actionable correctness, security, or repository-rule issues identified.
Summary
The PR fixes Loom imports from the CLI by conditionally adding optional owner and Space fields only when supplied, preventing absent options from being serialized as JSON null.
Reviews (1) · Last reviewed commit: "fix: omit unset Loom import fields in CL..."