fix(recording): detect microphone starvation during voip calls - #2313
Open
ManthanNimodiya wants to merge 5 commits into
Open
ManthanNimodiya wants to merge 5 commits into
ManthanNimodiya wants to merge 5 commits into
Conversation
Contributor
Author
Track keepalive silence dominance and emit stalled health events when input frames are starved without intentional muting. Signed-off-by: ManthanNimodiya <manthannimodiya989898@gmail.com>
…rvation Record stall start timestamp to compute cumulative elapsed time and prevent repeated stall health events during sustained starvation. Signed-off-by: ManthanNimodiya <manthannimodiya989898@gmail.com>
ManthanNimodiya
force-pushed
the
fix/mic-voip-silence-detection
branch
from
September 22, 2026 16:17
b89c95d to
1c21d7e
Compare
Provide ImageUploads service stub to satisfy embed page rendering dependencies. Signed-off-by: ManthanNimodiya <manthannimodiya989898@gmail.com>
… signals Explicitly provide generic type parameters to makePersisted calls across desktop routes. Signed-off-by: ManthanNimodiya <manthannimodiya989898@gmail.com>
Rebuild MCP card bundle to ensure mcp-card:check verification succeeds in CI. Signed-off-by: ManthanNimodiya <manthannimodiya989898@gmail.com>
ManthanNimodiya
force-pushed
the
fix/mic-voip-silence-detection
branch
from
September 23, 2026 12:59
8899800 to
92b620c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
When VoIP calls pre-empt hardware microphone capture, synthetic keepalive silence indefinitely masked the stall and reported false recording success. This adds keepalive silence ratio tracking to detect hardware starvation while preserving intentional mute behavior and emits pipeline stall health events.
Changes
is_audio_starvedhelper to evaluate silence frame dominance (PipelineHealthEvent::Stalledwhen starvation persists.Checklist
The PR appears safe to merge; the previous repeated-event and understated-duration issue is fully addressed.
Findings
Fix with agent prompt
Summary
The PR detects microphone starvation when synthetic keepalive silence dominates unmuted capture and emits a single pipeline-stall event for each sustained starvation episode.
Reviews (2) · Last reviewed commit: "fix(recording): track cumulative stall d..."