Added splicing plumbing - #736
Merged
Merged
Conversation
ihordiachenko
force-pushed
the
feature/splicing_support
branch
4 times, most recently
from
July 22, 2026 00:53
6de2272 to
2b9b71d
Compare
ihordiachenko
marked this pull request as ready for review
July 22, 2026 13:19
cdecker
reviewed
Aug 5, 2026
Collaborator
|
Sorry for the |
ihordiachenko
force-pushed
the
feature/splicing_support
branch
2 times, most recently
from
August 11, 2026 18:14
b543a5b to
4b3fa1b
Compare
ihordiachenko
force-pushed
the
feature/splicing_support
branch
from
August 12, 2026 16:06
fc88d4e to
02095aa
Compare
cdecker
force-pushed
the
feature/splicing_support
branch
from
September 3, 2026 12:38
02095aa to
162cc0a
Compare
Collaborator
|
Ok, reviewed once more, and rebased. This is ready to go in, sorry for the slowness in reviewing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR prepares Greenlight for splicing support without waiting for the VLS side of things. This establishes the CLN API, binding, persistence, and policy boundaries needed for later signer integration.
What Changed
Trade-offs
experimental-splicingCargo feature but cannot complete until VLS provides the required signing proofs.Handling PBSTs
Greenlight links each splice PSBT to its splice session during
SpliceInitand records whether funding and signing were authorized. The signer rejects it unless the link and signing approval are present. Unrelated PSBTs remain outside splice handling and follow the existing signer policy.