Conversation
Extend the PoX-5 builder tests with a tstxsignet describe block covering the staking build flows on the staking-testnet coin (chain ID 1280, tx version 0x80): - stake / stake-update / unstake / register-for-bond (L1 lockup and sBTC) serialize with the 8000000500 tx prefix, target the statics stakingContractAddress and carry the expected pox-5 function args - rebuild round-trip: from(rawTxHex) -> build is byte-identical for stake, unstake and register-for-bond - factory routing: parsed stake txs route to Pox5Builder via isValidContractCall on tstxsignet statics - toJson exposes fee, nonce and sender - negative: signer-manager principal without the address.contract-name shape rejects with the existing validation error Test-only change: no src/, dependency or fixture modifications. All 204 pre-existing tests and every serialized fixture stay byte-identical (212 passing / 0 failing). Ticket: CSHLD-1865
Contributor
Contributor
|
|
Add wallet-creation coverage to the tstxsignet suite: - the coin generates wallet keypairs (xpub/xprv triples) - a derived wallet address is a valid testnet ST... address - a Wallet binds to the tstxsignet coin (mirrors the wallet data the API returns for a created wallet) - testnet wallet address validation accepts ST... forms Ticket: CSHLD-1865
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CSHLD-1865 (parent epic: CSHLD-1840)
What
Test-only change extending
test/unit/transactionBuilder/pox5Builder.tswith aPoX-5 Builder on tstxsignetdescribe block. Nosrc/, dependency or fixture modifications.The existing PoX-5 builder tests (SI-1486) cover the builders on
tstx(chain ID 2147483648); thetstxsignetcoin (Stacks Foundation staking-testnet, chain ID 1280, tx version 0x80, landed in #9843) had no staking-build coverage. wallet-platform builds PoX-5 staking transactions fortstxsigneton staging, so the serialization needs the same test depth on that coin.Test cases (8 new)
stakebuild — tx hex prefix8000000500(0x80 version + chain ID 1280); payload targets the staticsstakingContractAddress(ST000000000000000000002AMW42H), contractpox-5, fnstake, 5 args (signer-manager principal, uint amount, uint cycles, uint start-burn-ht, none) with values assertedstake-updatebuild — prefix; fnstake-update; new + old signer-manager principals, cycles-to-extend, amount-increase, noneunstakebuild — prefix; fnunstake; single old-signer-manager principal argregister-for-bondbuild (L1 btc lockup + sBTC variant) — prefix; lockup responseOk/responseErr arg shapesfactory.from(rawTxHex)→build()is byte-identical for stake, unstake and register-for-bond (proves the parse path handles chain-1280 txs)Pox5BuilderviaisValidContractCallon tstxsignet statics (true), and a swapped contract address routes nowhere (false)toJsonsanity — fee, nonce, 64-hex id, sender addressaddress.contract-nameshape rejects with the existing validation errorVerification
sdk-coin-stxunit suite: 212 passing / 0 failing (204 pre-existing baseline unchanged; all serialized fixtures byte-identical)