fix(sdk-core): bind EdDSA MPCv1 external signer signing state - #9857
Open
danielpeng1 wants to merge 1 commit into
Open
danielpeng1 wants to merge 1 commit into
danielpeng1 wants to merge 1 commit into
Conversation
Bind the encrypted signing state to its transaction request and the BitGo commitment, and reject reusing a signing nonce across different signing attempts. BREAKING CHANGE: EdDSA MPCv1 external signer R share generation now requires bitgoToUserCommitment and returns encryptedUserToBitgoRShare. G share generation takes encryptedUserToBitgoRShare and walletPassphrase instead of userToBitgoRShare. Ticket: WCN-2112
Contributor
Contributor
|
|
danielpeng1
requested a deployment
to
breaking-changes-override
September 29, 2026 21:39 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
danielpeng1
marked this pull request as ready for review
September 29, 2026 22:09
| }) | ||
| ), | ||
| /** User's R share sent to BitGo containing cryptographic commitments for EDDSA G share generation */ | ||
| userToBitgoRShare: optional( |
Contributor
There was a problem hiding this comment.
why we are removing it? it would break MPCv1 wallets?
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens the EdDSA MPCv1 external signer signing flow.
Breaking change
Only affects EdDSA MPCv1 wallets using BitGo Express external signing, or custom R/G share generators:
bitgoToUserCommitment, and also returnsencryptedUserToBitgoRShareencryptedUserToBitgoRShare(returned by the R step) instead ofuserToBitgoRShareThe BitGo Express instance and its external signer must run the same version (noted in
EXTERNAL_SIGNER.md).Testing
Ticket: WCN-2112