Restructure material entity branch and fix axioms - #37
Merged
Merged
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Material entity branch (IDPO:0000091-0000098)
Two modelling errors fixed:
protein region(IDPO:0000095) wasis_aprotein, entailing that every IDRand every ordered region is itself a protein. Now BFO:0000024 (fiat object
part) with
part_of some protein.condensate(IDPO:0000092) wasis_acompound, which is defined as amolecule. A condensate is an assembly of many molecules, so the genus did not
hold. Now BFO:0000027 (object aggregate).
Also:
compoundandproteinre-parented from BFO:0000040 to BFO:0000030 (object)biomolecular condensate: addedoutput of some 'biomolecular condensate formation'(RO:0002353)hasOBONamespacechanged fromcompound/proteintomaterial_entity,consistent with the other branches
Logical definitions
Added:
protein and ('has quality' some 'disorder state')'protein region' and ('has quality' some 'disorder state')'protein region' and ('has quality' some 'order state')Other fixes
Several typos were fixed in definitions, the ontology roots were updated. No terms added, removed, obsoleted or relabelled.
Axioms modified:
-IDPO:0000001
SubClassOf: 'quality of' some (protein or 'protein region')-IDPO:0000030
SubClassOf: 'function of' some 'intrinsically disordered region'-IDPO:0000085
SubClassOf: 'role of' some 'intrinsically disordered region'-IDPO:0000100
SubClassOf: 'role of' some (protein or 'protein region')Axioms removed:
-IDPO:0000030
SubClassOf: 'has quality' some 'disorder state'