CI (Win32): register ProcDump as the postmortem debugger so crashes leave a dump - #247
Open
matthargett wants to merge 1 commit into
Open
matthargett wants to merge 1 commit into
matthargett wants to merge 1 commit into
Conversation
…eave a dump The WER LocalDumps registration produced no .dmp on the runner image for a plain access violation, so the "crash dumps" artifact only ever held the exe and pdb. ProcDump installed as the AeDebug handler writes a full dump for any crashing process regardless of WER's policy; the existing upload step picks it up from the same folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
build-win32.ymlenables WERLocalDumpsforUnitTests.exe, but on the runner image no.dmpappeared for a plain access violation (an intermittent Hermes crash in the fork's Worker tests, exit0xC0000005): the*-crash-dumpsartifact only ever contained the exe and pdb, so the crash could not be diagnosed post mortem.Change
A step downloads Sysinternals ProcDump and registers it as the just-in-time (AeDebug) debugger writing full dumps into the same
Dumpsfolder the artifact step uploads. That path does not depend on WER's policy, needs no change to how the tests are launched, and leaves the process exit code untouched. The WER registration stays.Workflow-only change. Fork twin: rebeckerspecialties#31.