CI (Linux): symbolize sanitizer reports - #243
Open
matthargett wants to merge 1 commit into
Open
matthargett wants to merge 1 commit into
matthargett wants to merge 1 commit into
Conversation
The sanitizer runtimes look for an unversioned llvm-symbolizer; the runner image has none, so every frame of an ASan/UBSan/TSan report is a bare address and a red job is undiagnosable. Install llvm and point the runtimes at /usr/bin/llvm-symbolizer explicitly (UBSan also prints a stack with print_stacktrace=1).
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The workflow changes correctly provide and configure symbolization for Linux sanitizer jobs.
Pull request overview
Configures Linux sanitizer CI to install and use llvm-symbolizer for readable reports.
Changes:
- Installs the LLVM toolchain.
- Configures symbolization and UBSan stack traces.
File summaries
| File | Description |
|---|---|
.github/workflows/build-linux.yml |
Adds LLVM and sanitizer symbolizer options. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 16, 2026
matthargett
added a commit
to rebeckerspecialties/JsRuntimeHost
that referenced
this pull request
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a Linux sanitizer job reports something, every frame is a bare address (
#0 <null> <null> (UnitTests+0x2b5d208)): the sanitizer runtimes look for an unversionedllvm-symbolizerand the runner image does not have one (theclangpackage pulls only versioned tools). A red ASan/UBSan/TSan job therefore cannot be diagnosed from the log — on the fork, 153 TSan reports had to be re-run with a symbolizer before they could be attributed.Changes
llvmalongsideclang(it provides/usr/bin/llvm-symbolizer).TSAN_OPTIONS,ASAN_OPTIONSandUBSAN_OPTIONSat it explicitly (external_symbolizer_path), and enableprint_stacktrace=1for UBSan.Workflow-only change. Fork twin: rebeckerspecialties#27.