Do not register SWA auth scheme when auth property is omitted - #3813
Open
aaronburtle wants to merge 2 commits into
Open
aaronburtle wants to merge 2 commits into
aaronburtle wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed changes meet the intended authentication behavior and include integration coverage.
Pull request overview
Updates authentication defaults so omitted configuration uses Unauthenticated while preserving late-configuration EasyAuth behavior.
Changes:
- Adjusts startup authentication registration.
- Resolves missing or blank providers to
Unauthenticated. - Adds integration coverage for startup and request-pipeline scenarios.
File summaries
| File | Description |
|---|---|
src/Service/Startup.cs |
Separates loaded-configuration defaults from late-configuration bootstrap. |
src/Service.Tests/Configuration/ConfigurationTests.cs |
Tests omitted authentication and late-configuration scenarios. |
src/Core/AuthenticationHelpers/ClientRoleHeaderAuthenticationMiddleware.cs |
Selects unauthenticated handling for missing or blank providers. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
RubenCerna2079
approved these changes
Sep 18, 2026
RubenCerna2079
left a comment
RubenCerna2079
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Approving as I assume comment will be addressed.
| ]); | ||
| HttpContext context = await server.SendAsync(requestContext => | ||
| { | ||
| requestContext.Request.Path = "/api/not-an-entity"; |
Contributor
There was a problem hiding this comment.
Why do we use a non-existent entity? Wouldn't it be better to use one that already exists?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #3812
What is this change?
runtime.host.authenticationnow usesUnauthenticated, matching the documented default, rather than falling back to EasyAuth.Unauthenticatedas the production default.Unauthenticated. This also protects development mode, where EasyAuth handlers remain registered for hot reload.How was this tested?
TestServer, with the authentication property literally omitted and both Azure hosting indicators unset./configurationand/configuration/v2, including readiness before hydration and authentication afterward.DAB_CONFIG_AUTH_TOKENboth unset and set. The compatibility test supplies the token only on its configuration POST.Sample Request(s)
N/A