Updates to allow for log folders to be directly in the root of a bucket - #14995
Updates to allow for log folders to be directly in the root of a bucket#14995gallen-ms wants to merge 8 commits into
Conversation
Updated version numbers for solution and data connector. Updated connector to accept an empty s3BucketPrefix value and when provided the user should supply a trailing slash
Updated the release notes to include version 3.3.2 changes.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Cisco Umbrella solution to support Amazon S3 log folders located directly at the bucket root by making the S3 bucket prefix optional and adjusting prefix/path handling and guidance.
Changes:
- Bumped solution/connector versions to 3.3.2 and added release notes entry.
- Made
s3BucketPrefixoptional in the connector UI/template and updated instructional markdown. - Adjusted polling config path concatenation to avoid injecting a leading slash when prefix is empty.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Solutions/CiscoUmbrella/ReleaseNotes.md | Adds 3.3.2 release note describing optional prefix + trailing slash guidance. |
| Solutions/CiscoUmbrella/Package/mainTemplate.json | Makes prefix optional, updates UI/help text, and updates prefix concatenation logic. |
| Solutions/CiscoUmbrella/Data/Solution_CiscoUmbrella.json | Bumps solution version to 3.3.2. |
| Solutions/CiscoUmbrella/Data Connectors/CiscoUmbrella_CCP/CiscoUmbrella_PollingConfig.json | Updates prefix concatenation for each log type path. |
| Solutions/CiscoUmbrella/Data Connectors/CiscoUmbrella_CCP/CiscoUmbrella_DataConnectorDefinition.json | Makes prefix optional and adds guidance note + example update. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Hi gallen-ms Kindly verify the Copilot comments, make the necessary changes, and mark the conversations as resolved.
The .zip file is missing. Please package the solution using V3 tool Kindly attach the CCF connector connected-state screenshot. Thanks!! |
|
Hi gallen-ms Kindly review above comments. Thanks! |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated S3 bucket prefix handling and adjusted markdown content for clarity. Put whitespace trimming around bucket name
Normalize optional S3 bucket prefixes, regenerate the 3.3.2 package, and update release notes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>


Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: