Repository navigation
refactor: remove the routing plane UI except the llama target form - #7
Merged
Merged
Conversation
Drop the Kubernetes overview tab and its cluster fetch on every refresh, the saved ai-engine presets/connections selector and the unused routing history labels. The llama target control now only reads, probes, applies and resets the target.
Sebas1705
force-pushed
the
refactor/remove-routing-plane
branch
from
November 12, 2026 19:23
7453f77 to
f2e6c9e
Compare
Sebas1705
marked this pull request as ready for review
November 12, 2026 19:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Finding F3/F8 of the architecture review: the "point the AI engine somewhere else" capability is implemented in several overlapping places. The owner wants to keep only the llama target in
ai-engine. This is the Backoffice half; the BFF half is AxiomNode/bff-backoffice#9 (same branch name).ai-enginehas nothing dead, so it gets no PR.Stacking and overlap with open PRs
Stacked on #6 (
perf/phase2-frontend), so the base of this PR is that branch. #6 moved the label dictionaries intoi18n/dictionaries/*.tsand editsAIDiagnosticsPanel.tsxand two of the test files I rewrite; branching frommainwould conflict on every label removal. Merge #6 first, then retarget this PR tomain. #3 (fix/replace-public-ip-fixtures) only changes IP fixtures inservice-overview-panel.integration.test.tsxandsrc/.env.example; the tests it touches are rewritten here (no public IPs remain in them), so closing or rebasing #3 is trivial. #4 and #5 do not touch these files.Inventory of the routing plane in the UI (before this PR)
LOC are physical lines on the base branch.
fetchKubernetesOverview+KubernetesOverviewtypeServiceOverviewPanel.tsx(about 230 of its 841 lines),operationalSummary.ts(75)GET /v1/backoffice/kubernetes/overview, fetched on mount and on every auto-refresh tick even with the tab hidden/v1/backoffice/*)findPresetMatch),AiEngineTargetPresettypeuseAiEngineTargetState.ts(524 LOC hook),AiEngineTargetControl.tsx(339 LOC),domain/types/backoffice.tsGET/POST /ai-engine/presets,PUT/DELETE /ai-engine/presets/:idoverview.routingHistory.*(no view used them)i18n/labels.ts+ 4 dictionaries*.selector,*.optionsCount,*.newBtn/addBtn/saveBtn/deleteBtn,diag.target.*Preset*, ...)/ai-engine/probe, applies withPUT /ai-engine/target(probe first), resets withDELETE /ai-engine/target, broadcast refresh between panelsuseAiEngineTargetState.ts,AiEngineTargetControl.tsx, used byServiceOverviewPanelandAIDiagnosticsPanelGET/PUT/DELETE /ai-engine/target,POST /ai-engine/probeBehaviour change to be aware of: the card no longer has a saved-destination dropdown; the operator types host/protocol/port (and an optional label). The overview card now also has the "reset to environment target" button that only the AI diagnostics card had. Existing saved presets in the BFF state file are simply ignored.
Result
ServiceOverviewPanel.tsxgoes from 841 to 597 lines.vite build, raw / gzip kB): total 749.8 / 191.9 -> 728.9 / 187.7 (-21.0 / -4.2).ServiceOverviewPanelchunk 25.09 / 5.96 -> 15.66 / 4.43,useAiEngineTargetStatechunk 14.35 / 4.16 -> 10.20 / 3.16, entry chunk 212.93 / 66.30 -> 210.71 / 65.78,es31.24 / 8.86 -> 29.03 / 8.38.kubernetes/overviewrequest every refresh cycle (it was 1 BFF call fanning out to 6 Kubernetes API calls).Verification
npm run build(tsc -b + vite build) green;vitest run --coverage: 19 files, 154 tests green; coverage 93.56% statements, 85.9% branches (gate 85), 95.59% functions, 94.31% lines (gates 90/85/90/90).kubernetesrequest exists and that/ai-engine/presetsis never called.node_modules(nonpm ci); the project has no lint script.Depends on / ordering
The routes this UI stopped calling are removed in AxiomNode/bff-backoffice#9. This PR is safe to merge before or after it: the remaining UI only calls
GET/PUT/DELETE /v1/backoffice/ai-engine/targetandPOST /v1/backoffice/ai-engine/probe, which both PRs keep. The api-gateway proxy routes for the removed endpoints become dead (list in #9).