Repository navigation
fix: harden batch lifecycle and release 0.0.8 - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interrupted ingestion could discard consumed inputs, concurrent SQL completion writers could reuse result cursors, and failures around batch submission or artifact retention could strand work or delete replay data. Preserve uncommitted ingestion slices, validate resume before side effects, serialize claims/cursors, and make cancellation irreversible.
Refactor submission into explicit claim/chunk/remote-create boundaries; prevent SDK create retries, release pre-create claims/capacity, propagate deadlines, and avoid request-file accumulation while capacity is unavailable. Preflight both generated export leaves before any writes; exclude private handoff records from source distributions. Harden artifact paths and atomic writes, normalize provider output errors, reject newer schemas, and release completed input/result buffers. Prepare patch 0.0.8, retaining schema version 6.
Proof
Boundaries
One execution owner per run remains required. Arbitrary iterators recover only in process; remote create ambiguity still needs verified operator resolution. Deadlines remain cooperative. See
docs/design_docs/CODE_REVIEW_2026_11.mdfor findings, regression evidence and remaining limitations.Independent review and fresh repair verification passed at
6b9bd58491384021296ed816fda76146e993578e: zero major findings, including 16 additional adversarial export checks. All eight checks passed on this exact head in CI run 43115222768. The two earlier orphaned workflow records still report queued but have zero jobs and no commit checks; the current PR/commit rollup contains only the eight successful replacement checks. No additional branch-protection/ruleset checks are configured.