Skip to content

Enable editor automation and faster checks - #880

Merged
Eli Pinkerton (wallstop) merged 24 commits into
mainfrom
codex/goal-sep28-issues-ci-speed
Sep 28, 2026
Merged

Eli Pinkerton (wallstop) merged 24 commits into
mainfrom
codex/goal-sep28-issues-ci-speed

Conversation

@wallstop

@wallstop Eli Pinkerton (wallstop) commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

DISCLOSURE: LLM-GENERATED TEXT

Editor scripts can now repair missing prefab scripts, create sprite atlas configs, apply batch texture and sprite settings, and enable or disable analyzer policies without opening windows. The windows use the same APIs, so interactive and scripted actions share importer, asset-save, and partial-failure behavior.

The PR also normalizes Windows asset folder paths across editor discovery and repair, saves atlas config state before refresh, and guards batched atlas creation. Local contract checks run directly and use isolated PowerShell runspaces for synthetic fixtures, including EOL mutation cases. Git staging retries honor the configured lock timeout. The root npm lockfile is again ignored and absent from the final PR tree so Git URL installs receive the intended package layout; CI uses its existing no-lock install path.

Validation: Head 771ae636 passed local Unity 6000.4.6f1 sprite-settings tests 165/165 and progress-cleanup tests 14/14. Full Unity typecheck, both editor-test variants, 342 compiled documentation samples, strict MkDocs, spelling, formatting, preflight, no-lock npm install, and npm package validation passed. All nine hosted workflows passed on head 771ae636, including 93/93 contract checks and the full Unity matrix. EditMode totals increased by four on every selected Unity version and the single-threaded run; PlayMode and standalone totals held steady, with zero failures. The preceding head 8c0a1abb also passed all nine workflows. The EOL contract check on an earlier head took 5.5s versus 16.7s on its prior green head with 31 versus 27 assertions; this timing comparison is observational.

Editor APIs mutate assets and importers and can report partial failure after a write. The analyzer ruleset API documents that file changes are outside Unity Undo.

Fixes #879. Refs #821 and #869.

Commit the existing exact tool versions as one resolved graph. This lets local checks and CI use npm ci and gives CI a stable cache key. Keep the lock out of the Unity package and teach release tooling users how to update it.

Refs #879
Use isolated runspaces for pure-content fixtures so repeated child PowerShell starts no longer dominate local checks. Keep CLI binding smoke tests and require exact exits and diagnostics.

Refs #869
Editor scripts need to inspect and repair missing prefab components from explicit folders. Move the repair out of the window and report save and cleanup failures. Cover nested components, batch saves, and invalid input in Unity EditMode tests.

Refs #821

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fc1832f. Configure here.

Comment thread Editor/PrefabChecker.cs
The whole-tree Repo Lint gate found two comparisons in the new prefab API that used the unsupported direction. Swap their operands without changing behavior.

Refs #821
@wallstop Eli Pinkerton (wallstop) changed the title Expose prefab repair and speed local checks Expose prefab repair, fix editor folder paths, and speed local checks Sep 28, 2026
@wallstop Eli Pinkerton (wallstop) changed the title Expose prefab repair, fix editor folder paths, and speed local checks Expose editor repair APIs, fix path and atlas import settings, speed local checks Sep 28, 2026
@wallstop Eli Pinkerton (wallstop) changed the title Expose editor repair APIs, fix path and atlas import settings, speed local checks Expose editor automation APIs, fix atlas persistence, and speed local checks Sep 28, 2026
@wallstop Eli Pinkerton (wallstop) changed the title Expose editor automation APIs, fix atlas persistence, and speed local checks Enable editor automation and faster checks Sep 28, 2026
@wallstop
Eli Pinkerton (wallstop) merged commit fdc3a98 into main Sep 28, 2026
31 checks passed
@wallstop
Eli Pinkerton (wallstop) deleted the codex/goal-sep28-issues-ci-speed branch September 28, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pin npm tools for reproducible CI timing

1 participant