[Before forward-ports] Antalya 26.8: patch for SettingsChangesHistory - #2345
Conversation
…hangeshistory [Before forward-ports] Antalya 26.6: patch for SettingsChangesHistory
CI triage — 3 failing checks, 0 caused by this PR
None of these touch the code this PR changes ( 1 & 2 — PromQL Compliance / Build profile diff → infra (not PR-related)Both jobs errored out before doing any work, at the praktika runner's credential check: This is a GitHub-token/credential problem on the runner, not anything in the diff. A code change cannot produce this. Next step: re-run these two jobs. 3 — Stateless tests (amd_debug, parallel) → infra setup failure (not PR-related)The suite has exactly one sub-result, and it is the setup step, not a test: The server itself started cleanly: — which, notably, is positive evidence that this PR's changes to
Positive signals for this PR
Recommendation: re-run the three failing jobs; no code change is needed. Once the runner auth/network hiccups clear, this should go green. — @blau-ai · evidence from praktika |
Antalya patch for
SettingsChangesHistory, landed before forward-ports.When porting to future Antalya versions:
.tsvfile containing settings values in the latest Antalya release (more details in the comments intests/queries/0_stateless/03999_stateless_settings_history.sh) and rename it to that version, keeping the03999prefix —ci/jobs/scripts/find_tests.pymaps a data file to its owning test by five-digit prefix;src/Core/SettingsChangesHistory.cpp;ClickHouseVersion.cpp.When cherry-picking, do
cherry-pick -nto avoid picking:...antalya.tsvfile: it needs to be re-generated;SettingsChangesHistory.cpp: instead, take the Antalya-related sections from the previous Antalya release'sSettingsChangesHistory.cppand manually add them to the current file, commenting all lines with Antalya-specific settings.Changelog category (leave one):
CI/CD Options
Exclude tests:
Regression jobs to run: