[PWGCF] DptDpt - Fixing Megalinter cppcheck warnings

[victor-gonzalez]

No description provided.

[github-actions]

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 2 disabled

[victor-gonzalez]

@vkucera, in my view, the staying MegaLinter failure is due to cppcheck false positives. The templated functions are explicitly instantiated for the different kind of data and there are default ones for unexpected kinds. cppcheck only considers the default ones and, wrongly, assigns their behaviors to the others.

In any case, I fixed a few warnings which were actual errors which would have been manifested with certain configurations. The tool is extremely useful.

[alibuild]

Auto-approving on behalf of @victor-gonzalez.

[vkucera]

Hi @victor-gonzalez , thanks for the fixes and for reporting the false positives. I suspect one reason is that Cppcheck cannot know that LOGF(fatal aborts the processing.

[victor-gonzalez]

Hi @victor-gonzalez , thanks for the fixes and for reporting the false positives. I suspect one reason is that Cppcheck cannot know that LOGF(fatal aborts the processing.

My guess is that it is not able to properly track explicit template instantiations