[PWGDQ] Track rotation ep preserving mepm rotated legs - #17983
Merged
XiaozhiBai merged 13 commits intoSep 21, 2026
Merged
XiaozhiBai merged 13 commits into
XiaozhiBai merged 13 commits into
Conversation
ayatsujiringo
requested review from
XiaozhiBai,
alibuild,
iarsene,
mcoquet642 and
mguilbau
as code owners
September 20, 2026 12:01
github-actions
Bot
changed the title
…-preserving-mepm-rotated-legs
|
O2 linter results: ❌ 0 errors, |
added 2 commits
September 20, 2026 20:30
Collaborator
|
Error while checking build/O2Physics/code-check for 3c4f361 at 2026-09-20 14:49: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for 1cc3502 at 2026-09-20 14:52: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for 2a7605a at 2026-09-20 14:53: Full log here. |
Collaborator
Collaborator
|
Error while checking build/O2Physics/code-check for 20dee4c at 2026-09-20 14:57: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 2a7605a at 2026-09-20 14:59: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 20dee4c at 2026-09-20 15:07: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 1cc3502 at 2026-09-20 15:36: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 3c4f361 at 2026-09-20 16:00: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 1cc3502 at 2026-09-20 16:08: Full log here. |
Collaborator
|
Error while checking build/O2Physics/o2 for 3c4f361 at 2026-09-20 16:58: Full log here. |
XiaozhiBai
approved these changes
Sep 21, 2026
vkucera
reviewed
Sep 22, 2026
Comment on lines
+4089
to
+4093
| if (rotationphi2 >= o2::constants::math::TwoPI) { | ||
| rotationphi2 -= o2::constants::math::TwoPI; | ||
| } else if (rotationphi2 < 0) { | ||
| rotationphi2 += o2::constants::math::TwoPI; | ||
| } |
Collaborator
There was a problem hiding this comment.
@ayatsujiringo Why did you replace the constrainAngle function?
vkucera
reviewed
Sep 22, 2026
Comment on lines
+4574
to
+4578
| if (rotationphi2 >= o2::constants::math::TwoPI) { | ||
| rotationphi2 -= o2::constants::math::TwoPI; | ||
| } else if (rotationphi2 < 0) { | ||
| rotationphi2 += o2::constants::math::TwoPI; | ||
| } |
Collaborator
There was a problem hiding this comment.
Again, this should be done with constrainAngle.
vkucera
reviewed
Sep 22, 2026
Comment on lines
+4580
to
+4582
| ROOT::Math::PtEtaPhiMVector v1(t1.pt, t1.eta, t1.phi, m1); | ||
| ROOT::Math::PtEtaPhiMVector v2(t2.pt, t2.eta, rotationphi2, m1); | ||
| ROOT::Math::PtEtaPhiMVector v12 = v1 + v2; |
Collaborator
There was a problem hiding this comment.
Please consider using RecoDecay methods.
vkucera
reviewed
Sep 22, 2026
Comment on lines
+4589
to
+4590
| double Ptot1 = TMath::Sqrt(v1.Px() * v1.Px() + v1.Py() * v1.Py() + v1.Pz() * v1.Pz()); | ||
| double Ptot2 = TMath::Sqrt(v2.Px() * v2.Px() + v2.Py() * v2.Py() + v2.Pz() * v2.Pz()); |
Collaborator
There was a problem hiding this comment.
Please consider using RecoDecay methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add mix event rotated unlikesign pair to calculate rotated pair acceptance