Skip to content

[PWGLF] Add close pair QA for spin correlation and fine centrality calibration of ZDC SP - #17972

Merged
skundu692 merged 1 commit into
AliceO2Group:masterfrom
skundu692:zdcspin
Sep 19, 2026
Merged

skundu692 merged 1 commit into
AliceO2Group:masterfrom
skundu692:zdcspin

Conversation

@skundu692

Copy link
Copy Markdown
Collaborator

… of ZDC SP

@github-actions github-actions Bot added the pwglf label Sep 19, 2026
@github-actions github-actions Bot changed the title Add close pair QA for spin correlation and fine centrality calibration of ZDC SP [PWGLF] Add close pair QA for spin correlation and fine centrality calibration of ZDC SP Sep 19, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 195 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b0a66d9 at 2026-09-19 15:11:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 326 warnings.'
Found 1 errors and 326 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/42846a631ad2aee8b086f9d97b5871db5be11f57/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:3368:36: error: std::move of the variable 'branch' of the trivially-copyable type 'lambdaspincorrderived::PendingV6Branch' has no effect [performance-move-const-arg,-warnings-as-errors]
++ [[ 326 -gt 0 ]]
++ cat /sw/BUILD/42846a631ad2aee8b086f9d97b5871db5be11f57/O2Physics-code-check/warnings.txt
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:238:13: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:268:11: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:294:11: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:368:9: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:379:15: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/TableProducer/Common/zdc2stagecalibration.cxx:380:15: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:184:14: warning: variable 'gFixedLLRep1' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:184:14: warning: variable 'gFixedLLRep1' provides global access to a non-const object; consider making the pointed-to data 'const' [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:185:14: warning: variable 'gFixedULRep1' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:185:14: warning: variable 'gFixedULRep1' provides global access to a non-const object; consider making the pointed-to data 'const' [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:186:14: warning: variable 'gFixedALALRep1' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:186:14: warning: variable 'gFixedALALRep1' provides global access to a non-const object; consider making the pointed-to data 'const' [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:188:14: warning: variable 'gFixedLLRep2' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:188:14: warning: variable 'gFixedLLRep2' provides global access to a non-const object; consider making the pointed-to data 'const' [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:189:14: warning: variable 'gFixedULRep2' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:189:14: warning: variable 'gFixedULRep2' provides global access to a non-const object; consider making the pointed-to data 'const' [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:190:14: warning: variable 'gFixedALALRep2' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:190:14: warning: variable 'gFixedALALRep2' provides global access to a non-const object; consider making the pointed-to data 'const' [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:192:8: warning: constructor does not initialize these fields: ccdb, hweight1, hweight2, hweight3, hweight4, hweight12, hweight22, hweight32, hweight42 [cppcoreguidelines-pro-type-member-init]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1133:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1135:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1139:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1141:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1188:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1190:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1192:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1195:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1197:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1199:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1211:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1213:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1215:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1218:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1220:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1222:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1248:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1250:31: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1320:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/Strangeness/lambdaspincorrderived.cxx:1322:33: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for b0a66d9 at 2026-09-19 15:12:

No log files found

Full log here.

@skundu692
skundu692 enabled auto-merge (squash) September 19, 2026 14:54

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @skundu692.

@skundu692
skundu692 merged commit 5b38f03 into AliceO2Group:master Sep 19, 2026
13 of 15 checks passed
@vkucera

vkucera commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

@skundu692 Please fix the errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants