Conversation
rbailhac
requested review from
alibuild,
dsekihat,
feisenhu,
hscheid,
jokonig and
mikesas
as code owners
September 18, 2026 08:20
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
feisenhu
approved these changes
Sep 18, 2026
| template <bool dont_require_pteta = false, typename TTrack> | ||
| bool IsSelectedTrack(TTrack const& track) const | ||
| { | ||
| if (!track.hasITS() || !track.hasTPC()) { |
Collaborator
There was a problem hiding this comment.
I agree with the PR to remove these lines.
As there is a check, requiring a ITS and TPC hit if standalone ITS tracks not used [1], this should not have an effect for analysis in which the flag is not used.
For future PRs, there is still some need to introduce a TPC only case.
And currently there is no check for hasITS() when ITS standalone tracks are used.
[1] Line 238-240
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the possibility to check ITS-TPC matching efficiency. Later are exactly the same lines of code if ITS standalone are not included:
if (!mIncludeITSsa && (!track.hasITS() || !track.hasTPC())) { // track has to be ITS-TPC matched track
return false;
}