[PWGUD] updates to upcRhoAnalysis.cxx by jjuracka · Pull Request #17957 · AliceO2Group/O2Physics

jjuracka · 2026-09-17T21:02:01Z

A collection of updates to personal task.

Includes some bug fixes, changes of defaults for configurables, edits of axis specs, addition of columns into derived data, and a new process function to analyse reconstructed MC with access to truth-level info.

…liceO2Group#16276)

…6271)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

…al tracks (AliceO2Group#16279)

…gn` in `taskPtFlucCharmHadrons.cxx` (AliceO2Group#16230)

…ck selections (AliceO2Group#16260)

…ent loss, splitting (AliceO2Group#16284)

)

…ck-track correlation (AliceO2Group#16291) Co-authored-by: Shirajum Monira <shirajum.monira@cernch>

…iciency (AliceO2Group#16296) Co-authored-by: Shirajum Monira <shirajum.monira@cernch>

…2Group#16289) Co-authored-by: Lucamicheletti92 <luca.mike93@gmail.com>

…uest (AliceO2Group#16297)

…16287) Co-authored-by: Henrik Fribert <ge35huh@nidoqueen.ktas.ph.tum.de>

…iceO2Group#16259)

…vents (AliceO2Group#16128) Co-authored-by: Cristian Moscatelli <cmoscate@gr3srv.ts.infn.it> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

…alculations. (AliceO2Group#16002) Co-authored-by: Copilot <copilot@github.com>

…ceO2Group#16285)

…liceO2Group#16305)

…Group#16310)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

…rage (AliceO2Group#16544)

…Group#16547)

github-actions · 2026-09-17T21:02:18Z

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 0 disabled

Please consider the following formatting changes to AliceO2Group#17957

alibuild · 2026-09-18T01:30:10Z

Error while checking build/O2Physics/code-check for 2f8250f at 2026-09-18 03:30:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 89 warnings.'
Found 2 errors and 89 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/527b104ff238f71b652bba8d47b7794cc9ac254b/O2Physics-code-check/errors.txt
PWGUD/Tasks/upcRhoAnalysis.cxx:809:31: error: the variable 'p1' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference [performance-unnecessary-copy-initialization,-warnings-as-errors]
PWGUD/Tasks/upcRhoAnalysis.cxx:915:7: error: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
++ [[ 89 -gt 0 ]]
++ cat /sw/BUILD/527b104ff238f71b652bba8d47b7794cc9ac254b/O2Physics-code-check/warnings.txt
PWGUD/Tasks/upcRhoAnalysis.cxx:204:15: warning: member 'pcEtaCut' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
PWGUD/Tasks/upcRhoAnalysis.cxx:205:13: warning: member 'nExpectedPions' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
PWGUD/Tasks/upcRhoAnalysis.cxx:206:26: warning: member 'runNumbers' of type 'const std::vector<int>' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
PWGUD/Tasks/upcRhoAnalysis.cxx:306:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:349:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:437:65: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:465:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoAnalysis.cxx:466:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoAnalysis.cxx:467:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoAnalysis.cxx:566:55: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGUD/Tasks/upcRhoAnalysis.cxx:568:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGUD/Tasks/upcRhoAnalysis.cxx:596:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:601:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:607:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:612:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:617:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:623:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:630:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:637:44: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:644:54: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:660:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:665:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:670:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:675:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:680:53: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:685:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:690:93: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:695:100: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:700:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:705:147: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:711:27: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:717:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:722:126: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:727:70: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:750:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:752:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGUD/Tasks/upcRhoAnalysis.cxx:752:9: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:760:40: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

vkucera · 2026-09-18T07:14:06Z

Please don't reinvent the wheel. There is RecoDecay::constrainAngle for this.

vkucera · 2026-09-18T07:24:32Z

@jjuracka Your branch is not rebased correctly.

Shunsuke-Kurita and others added 30 commits June 6, 2026 10:18

[PWGDQ] Add e-mu pairing with MC matching to dqEfficiency_withAssoc (A…

66b7130

…liceO2Group#16276)

[PWGCF] Add dedicated PbPb processing function (AliceO2Group#16283)

24a0afa

[PWGDQ] use configurable vector for ML input features (AliceO2Group#1…

3a7d1bd

…6271)

[ALICE3] Only fill enabled histograms in otf-tof (AliceO2Group#16282)

e073e18

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

[PWGCF] Update in MFT track selection and added extra colums for glob…

9f94395

…al tracks (AliceO2Group#16279)

[PWGHF] update the default settings and correct the `getCandMassAndSi…

d6a7749

…gn` in `taskPtFlucCharmHadrons.cxx` (AliceO2Group#16230)

[PWGLF] Changed ptmultCorr track selections to align with piKpRAA tra…

a3cee13

…ck selections (AliceO2Group#16260)

[DPG] major_update_producer (AliceO2Group#16257)

509a9ad

[PWGLF] Jet reconstruction with V0s + MC models process function + Ev…

a084847

…ent loss, splitting (AliceO2Group#16284)

[ALICE3] Split otf particle from a3 track utilities (AliceO2Group#16288)

b40884a

[PWGLF] Replace cone radius calculation with rJet (AliceO2Group#16292)

634c073

[PWGLF] Omegahm: data for deco (AliceO2Group#16278)

e9533e8

[ALICE3] Add particle production time to otf decayer (AliceO2Group#16290

8c9ff56

)

[PWGCF] FU: efficiency and D0 tasks update (AliceO2Group#16293)

9cf1921

[PWGCF] FemtoUniverse Cascase Task -- added process functions for tra…

6c666e5

…ck-track correlation (AliceO2Group#16291) Co-authored-by: Shirajum Monira <shirajum.monira@cernch>

[PWGCF] FemtoUniverse V0 Task -- added ccdb timestamp configs for eff…

00033f7

…iciency (AliceO2Group#16296) Co-authored-by: Shirajum Monira <shirajum.monira@cernch>

[PWGDQ] Fixing issue with event mixing in table reader + flow (AliceO…

e746b65

…2Group#16289) Co-authored-by: Lucamicheletti92 <luca.mike93@gmail.com>

[PWGDQ] add code to emulate a shift of the dipole (AliceO2Group#16294)

739c94d

[PWGHF] Cut variation: add QA histograms, save output upon user's req…

718cdbb

…uest (AliceO2Group#16297)

[Common] Do not add configurables when not needed. (AliceO2Group#16298)

541b9f7

[ALICE3] TrackerPID improved plotting and LUT handling (AliceO2Group#…

e497cf0

…16287) Co-authored-by: Henrik Fribert <ge35huh@nidoqueen.ktas.ph.tum.de>

[PWGDQ] Add track-to-collision association in dalitzSelection.cxx (Al…

56441b2

…iceO2Group#16259)

[PWGLF] Add new task: PWGLF/TableProducer/Nuspex/deuteronInTriggeredE…

7ee5bb3

…vents (AliceO2Group#16128) Co-authored-by: Cristian Moscatelli <cmoscate@gr3srv.ts.infn.it> Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

[PWGJE] Update to jetD0AngSubstructure.cxx to include Monte Carlo c…

ed2e880

…alculations. (AliceO2Group#16002) Co-authored-by: Copilot <copilot@github.com>

[PWGLF] Remove jet area cut and use uniform area for UE estimate (Ali…

bc1d314

…ceO2Group#16285)

[PWGLF] Change histo filling in MC process (AliceO2Group#16301)

1833f31

[PWGJE] Add precompiled headers for HF jetSubstructure output tasks (A…

9e5ca6c

…liceO2Group#16305)

[PWGLF] Fix bug (AliceO2Group#16309)

6c53778

[PWGLF] Add process function for data in minimum bias events (AliceO2…

a304f1d

…Group#16310)

[PWGUD] Add RCT flag checks in UPCCandidateProducer (AliceO2Group#16255)

535282a

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>

SwatiSaha-1997 and others added 18 commits June 6, 2026 10:19

[PWGCF] Added calculation profiles for number of triplet weighted ave…

226996f

…rage (AliceO2Group#16544)

[PWGCF] Add multNTracksPV multiplicity estimator in the task (AliceO2…

09315dd

…Group#16547)

[PWGCF] Fix: define size of vector (AliceO2Group#16548)

06a4f14

Merge branch 'AliceO2Group:master' into update

7688041

change axes

059b90d

add phi resolution plots for MC

81d90aa

... and fill them

c0884a5

small bug in DG process function + adjusted runlist for pass5

278d73d

add colllision reco mode checker

1f111a5

changes in PID histos

9ec46fc

add switch for application of PID before creating derived data

2b21014

adding some histos for MC

fa4c26a

removing "magic number"

6e1149e

Merge branch 'AliceO2Group:master' into update

23767a3

axis name bugfix

bfe55c0

add fit into resolution derived data

0de1eeb

change default rct flag

e5d918e

added new process function to analyze MC reco with truth info

fa20bfd

jjuracka requested review from alibuild, amatyja and rolavick as code owners September 17, 2026 21:02

github-actions Bot added the pwgud label Sep 17, 2026

Please consider the following formatting changes

add2eab

alibuild mentioned this pull request Sep 17, 2026

Please consider the following formatting changes to #17957 jjuracka/O2Physics#14

Merged

Merge pull request #14 from alibuild/alibot-cleanup-17957

2f8250f

Please consider the following formatting changes to AliceO2Group#17957

vkucera reviewed Sep 18, 2026

View reviewed changes

jjuracka closed this Sep 18, 2026

Navigation Menu

[PWGUD] updates to upcRhoAnalysis.cxx - #17957

[PWGUD] updates to upcRhoAnalysis.cxx#17957
jjuracka wants to merge 452 commits into
AliceO2Group:masterfrom
jjuracka:update

jjuracka commented Sep 17, 2026

Uh oh!

github-actions Bot commented Sep 17, 2026

Uh oh!

alibuild commented Sep 18, 2026

Uh oh!

vkucera Sep 18, 2026 •

edited

Loading

Uh oh!

vkucera commented Sep 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

20 participants

Conversation

jjuracka commented Sep 17, 2026

Uh oh!

github-actions Bot commented Sep 17, 2026

Uh oh!

alibuild commented Sep 18, 2026

Uh oh!

vkucera Sep 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vkucera commented Sep 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

20 participants

vkucera Sep 18, 2026 •

edited

Loading