Skip to content

[PWGLF] INEL > 0 fix and new DCA parametrization - #17950

Merged
abmodak merged 2 commits into
AliceO2Group:masterfrom
lucasjsilva:Inelgt0DCAfix
Sep 18, 2026
Merged

abmodak merged 2 commits into
AliceO2Group:masterfrom
lucasjsilva:Inelgt0DCAfix

Conversation

@lucasjsilva

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 6 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title INEL > 0 fix and new DCA parametrization [PWGLF] INEL > 0 fix and new DCA parametrization Sep 17, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b14a2c0 at 2026-09-17 20:51:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 12 warnings.'
Found 1 errors and 12 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/443e36d2a12e02d6d796ee4b1314b3afd1b059c0/O2Physics-code-check/errors.txt
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:67:48: error: unused variable 'TrackSelectionDca' [clang-diagnostic-unused-const-variable,-warnings-as-errors]
++ [[ 12 -gt 0 ]]
++ cat /sw/BUILD/443e36d2a12e02d6d796ee4b1314b3afd1b059c0/O2Physics-code-check/warnings.txt
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:72:10: warning: variable 'axisEvent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:73:10: warning: variable 'axisVtxZ' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:74:10: warning: variable 'axisEta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:75:10: warning: variable 'axisPhi' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:76:10: warning: variable 'axisCollSel' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:80:8: warning: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:228:90: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:230:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:246:90: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:248:86: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:592:23: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/GlobalEventProperties/studyPnch.cxx:623:9: warning: do not use 'else' after 'continue' [readability-else-after-return]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

Comment out the TrackSelectionDca flag definition.
@abmodak
abmodak merged commit ab4d79a into AliceO2Group:master Sep 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants