Skip to content

[PWGEM] PhotonMeson: Add task for event normalization on derived data - #17875

Open
jokonig wants to merge 1 commit into
AliceO2Group:masterfrom
jokonig:master
Open

jokonig wants to merge 1 commit into
AliceO2Group:masterfrom
jokonig:master

Conversation

@jokonig

@jokonig jokonig commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator
  • If only events with a certain number of photons (or any other kind of selection) are stored in the derived data, the table "PMEvSelBits" in the event selection task can store the event selection bits. Hence, the number of selected events before the specific selection on the number of photons etc. can be retrieved.
  • This new task just loops over these event-selection bits and stores them in a histogram.
  • For future: Also store it as a function of multiplicity etc.

@github-actions github-actions Bot added pwgem photon Photon and neutral meson PAG label labels Sep 10, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 2 errors, ⚠️ 0 warnings, 🔕 0 disabled

- If only events with a certain number of photons (or any other kind of selection) are stored in the derived data, the table "PMEvSelBits" in the event selection task can store the event selection bits. Hence, the number of selected events before the specific selection on the number of photons etc. can be retrieved.
- This new task just loops over these event-selection bits and stores them in a histogram.
- For future: Also store it as a function of multiplicity etc.
@alibuild

alibuild commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 681f61e at 2026-09-15 09:58:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 5 errors and 0 warnings.'
Found 5 errors and 0 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/cd18de5d4275378687aea11b601f93c2f64c4964/O2Physics-code-check/errors.txt
PWGEM/PhotonMeson/Tasks/eventNormalizationTask.cxx:25:1: error: included header TH1D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/eventNormalizationTask.cxx:38:45: error: no header providing "o2::framework::OutputObjHandlingPolicy" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/eventNormalizationTask.cxx:60:10: error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/eventNormalizationTask.cxx:61:21: error: no header providing "TH1" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGEM/PhotonMeson/Tasks/eventNormalizationTask.cxx:75:3: error: no header providing "PROCESS_SWITCH" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

@vkucera

vkucera commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

@jokonig Your PR introduces errors. Please fix them before merging.

@vkucera
vkucera marked this pull request as draft September 15, 2026 08:06
@dsekihat
dsekihat marked this pull request as ready for review September 16, 2026 15:47
@dsekihat

Copy link
Copy Markdown
Collaborator

PR should not be marked as draft due to the optional checks.

@vkucera

vkucera commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

@dsekihat The PR introduces errors from the category that has already been cleaned up and therefore adds regressions which should not be merged, as we agreed.

@dsekihat

Copy link
Copy Markdown
Collaborator

No. I didn't agree. Decision on merging PRs is taken by the code owners.

@vkucera

vkucera commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Decision on merging PRs is taken by the code owners.

Yes. And I am not preventing it. What is the problem?

@dsekihat

Copy link
Copy Markdown
Collaborator

As I wrote above, you are not supposed to move PRs to draft due to the optional checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

photon Photon and neutral meson PAG label pwgem

Development

Successfully merging this pull request may close these issues.

4 participants