[PWGHF] Adding D0/Lc analysis task by laszlogyulai · Pull Request #17808 · AliceO2Group/O2Physics

laszlogyulai · 2026-09-07T10:46:20Z

Adding a new analysis task for calculating the D0/Lambda_c yield ratio as a function of flattenicity

Please consider the following formatting changes to AliceO2Group#17807

github-actions · 2026-09-07T10:46:37Z

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

laszlogyulai · 2026-09-07T11:00:11Z

Dear codeowners,

Is it possible to overcome the "magic number" errors in the O2 linter / O2 linter (pull_request_target) check? In my opinion it would unnecessarily complicate the existing code. You can see an example of such a solution in the PWGLF/Tasks/GlobalEventProperties/flattenicityPikp.cxx file (lines 1814-1908)

vkucera · 2026-09-07T11:24:00Z

Dear codeowners,

Is it possible to overcome the "magic number" errors in the O2 linter / O2 linter (pull_request_target) check? In my opinion it would unnecessarily complicate the existing code. You can see an example of such a solution in the PWGLF/Tasks/GlobalEventProperties/flattenicityPikp.cxx file (lines 1814-1908)

The way to "overcome" it is to write it in a better way. From what I can see, you map some number to other numbers. So how about using a map or an array, for example?

Please consider the following formatting changes to AliceO2Group#17808

laszlogyulai · 2026-09-07T14:21:40Z

Dear codeowners,
Is it possible to overcome the "magic number" errors in the O2 linter / O2 linter (pull_request_target) check? In my opinion it would unnecessarily complicate the existing code. You can see an example of such a solution in the PWGLF/Tasks/GlobalEventProperties/flattenicityPikp.cxx file (lines 1814-1908)

The way to "overcome" it is to write it in a better way. From what I can see, you map some number to other numbers. So how about using a map or an array, for example?

Dear Vit,

Thank you for the nice and easy solution to the issue. Everything should be fine now.

vkucera · 2026-09-07T14:25:19Z

Dear codeowners,
Is it possible to overcome the "magic number" errors in the O2 linter / O2 linter (pull_request_target) check? In my opinion it would unnecessarily complicate the existing code. You can see an example of such a solution in the PWGLF/Tasks/GlobalEventProperties/flattenicityPikp.cxx file (lines 1814-1908)

The way to "overcome" it is to write it in a better way. From what I can see, you map some number to other numbers. So how about using a map or an array, for example?

Dear Vit,

Thank you for the nice and easy solution to the issue. Everything should be fine now.

Thanks @laszlogyulai for the implementation. It looks indeed much better now.

vkucera · 2026-09-07T14:41:11Z

Since you are adding a new file, please fix also the warnings.

Please consider the following formatting changes to AliceO2Group#17808

laszlogyulai · 2026-09-11T06:52:53Z

Dear code owners,

Can you tell me if anything is needed from my side at this point?

vkucera · 2026-09-11T09:21:26Z

Dear code owners,

Can you tell me if anything is needed from my side at this point?

You have not fixed the warnings.

Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>

laszlogyulai · 2026-09-14T07:43:50Z

Dear code owners,
Can you tell me if anything is needed from my side at this point?

You have not fixed the warnings.

Dear Vit,

From my side, I see that all checks are successful, and the only ones that are pending are awaiting a code owner approval.

vkucera · 2026-09-14T09:10:07Z

Dear Vit,

From my side, I see that all checks are successful, and the only ones that are pending are awaiting a code owner approval.

Please look at the O2 linter result at the top.

Please consider the following formatting changes to AliceO2Group#17808

laszlogyulai · 2026-09-14T10:12:33Z

Dear Vit,
From my side, I see that all checks are successful, and the only ones that are pending are awaiting a code owner approval.

Please look at the O2 linter result at the top.

Is everything fine now?

vkucera · 2026-09-14T12:31:46Z

Dear Vit,
From my side, I see that all checks are successful, and the only ones that are pending are awaiting a code owner approval.

Please look at the O2 linter result at the top.

Is everything fine now?

Looks good to me so far. Let's see the build results when the PR gets approved by the D2H coordinators.

zhangbiao-phy

Hi @laszlogyulai, Thanks! Looks good to me!

alibuild · 2026-09-17T08:58:28Z

Error while checking build/O2Physics/code-check for 6629a3a at 2026-09-17 10:58:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:408:36: error: 'const struct o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Join<o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >' has no member named 'isInelGt0'
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-09-17T10:28:15Z

Error while checking build/O2Physics/o2 for 6629a3a at 2026-09-17 12:28:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:127:25: error: unused variable 'doprocess' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:560:20: error: unused variable 'chi2PCA' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:482:19: error: unused variable 'flatCalibrated' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:469:39: error: unused parameter 'bcs' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:470:42: error: unused parameter 'tracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:642:19: error: unused variable 'flatCalibrated' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:740:17: error: unused variable 'minItsClustersOfProngs' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:741:17: error: unused variable 'minTpcCrossedRowsOfProngs' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:873:22: error: unused variable 'ptProng0' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:874:22: error: unused variable 'ptProng1' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:875:22: error: unused variable 'ptProng2' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:876:22: error: unused variable 'decayLength' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:877:22: error: unused variable 'chi2PCA' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:878:22: error: unused variable 'cpa' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:855:19: error: unused variable 'flatCalibrated' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:408:36: error: 'const struct o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Join<o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >' has no member named 'isInelGt0'
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-09-17T11:11:10Z

Error while checking build/O2Physics/staging for 6629a3a at 2026-09-17 13:11:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:127:25: error: unused variable 'doprocess' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:560:20: error: unused variable 'chi2PCA' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:482:19: error: unused variable 'flatCalibrated' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:469:39: error: unused parameter 'bcs' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:470:42: error: unused parameter 'tracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:642:19: error: unused variable 'flatCalibrated' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:740:17: error: unused variable 'minItsClustersOfProngs' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:741:17: error: unused variable 'minTpcCrossedRowsOfProngs' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:873:22: error: unused variable 'ptProng0' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:874:22: error: unused variable 'ptProng1' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:875:22: error: unused variable 'ptProng2' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:876:22: error: unused variable 'decayLength' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:877:22: error: unused variable 'chi2PCA' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:878:22: error: unused variable 'cpa' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:855:19: error: unused variable 'flatCalibrated' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:408:36: error: 'const struct o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Join<o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >' has no member named 'isInelGt0'
ninja: build stopped: subcommand failed.

Full log here.

laszlogyulai and others added 7 commits September 7, 2026 12:08

Adding D0/Lc analysis task

ee03074

Add files via upload

7c30b62

Please consider the following formatting changes

9239b5e

Merge pull request #1 from alibuild/alibot-cleanup-17807

9015b15

Please consider the following formatting changes to AliceO2Group#17807

Removing trailing spaces

c41ac52

Adding D0/Lc analysis task

59f2740

Delete PWGHF/D2H/Tasks/taskFlattenicityDLc.cxx

a5fc616

laszlogyulai requested review from NicoleBastid, alibuild, apalasciano, deepathoms, fcatalan92, fcolamar, fgrosa, gluparel, hahassan7, jpxrk, mfaggin, mmazzilli, singhra1994, stefanopolitano, vkucera, xinyepeng and zhangbiao-phy as code owners September 7, 2026 10:46

github-actions Bot added the pwghf PWG-HF label Sep 7, 2026

github-actions Bot changed the title ~~Adding D0/Lc analysis task~~ [PWGHF] Adding D0/Lc analysis task Sep 7, 2026

Renaming main struct

1539b7c

Merge pull request #3 from alibuild/alibot-cleanup-17808

b45729e

Please consider the following formatting changes to AliceO2Group#17808

vkucera reviewed Sep 7, 2026

View reviewed changes

Comment thread PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx Outdated

vkucera reviewed Sep 7, 2026

View reviewed changes

Comment thread PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx Outdated

laszlogyulai and others added 2 commits September 9, 2026 08:36

Implementing codeowner suggestions

4f07fbd

Please consider the following formatting changes

c832a7b

alibuild mentioned this pull request Sep 9, 2026

Please consider the following formatting changes to #17808 laszlogyulai/O2Physics#4

Merged

Merge pull request #4 from alibuild/alibot-cleanup-17808

289ccf5

Please consider the following formatting changes to AliceO2Group#17808

vkucera reviewed Sep 11, 2026

View reviewed changes

Comment thread PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx Outdated

vkucera reviewed Sep 11, 2026

View reviewed changes

Comment thread PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx Outdated

laszlogyulai and others added 2 commits September 11, 2026 11:32

Update PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx

778662c

Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>

Update PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx

098131f

Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>

laszlogyulai and others added 2 commits September 14, 2026 12:05

Resolving O2 linter warnings

6e82aed

Please consider the following formatting changes

3e5c5ee

alibuild mentioned this pull request Sep 14, 2026

Please consider the following formatting changes to #17808 laszlogyulai/O2Physics#5

Merged

Merge pull request #5 from alibuild/alibot-cleanup-17808

6629a3a

Please consider the following formatting changes to AliceO2Group#17808

zhangbiao-phy approved these changes Sep 17, 2026

View reviewed changes

zhangbiao-phy enabled auto-merge (squash) September 17, 2026 08:42

zhangbiao-phy disabled auto-merge September 17, 2026 10:58

Conversation

laszlogyulai commented Sep 7, 2026

Uh oh!

github-actions Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laszlogyulai commented Sep 7, 2026

Uh oh!

vkucera commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laszlogyulai commented Sep 7, 2026

Uh oh!

vkucera commented Sep 7, 2026

Uh oh!

Uh oh!

Uh oh!

vkucera commented Sep 7, 2026

Uh oh!

laszlogyulai commented Sep 11, 2026

Uh oh!

vkucera commented Sep 11, 2026

Uh oh!

Uh oh!

Uh oh!

laszlogyulai commented Sep 14, 2026

Uh oh!

vkucera commented Sep 14, 2026

Uh oh!

laszlogyulai commented Sep 14, 2026

Uh oh!

vkucera commented Sep 14, 2026

Uh oh!

zhangbiao-phy left a comment

Choose a reason for hiding this comment

Uh oh!

alibuild commented Sep 17, 2026

Uh oh!

alibuild commented Sep 17, 2026

Uh oh!

alibuild commented Sep 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Sep 7, 2026 •

edited

Loading

vkucera commented Sep 7, 2026 •

edited

Loading