[O2B-1541] Add explicit rct async provider of detectors

lib/public/services/detectors/detectorsProvider.js

@@ -16,11 +16,7 @@
 import { ObservableData } from '../../utilities/ObservableData.js';
 import { DetectorType, DATA_TAKING_DETECTOR_TYPES, QC_DETECTORS } from '../../domain/enums/DetectorTypes.js';
 import { DetectorOrders } from '../../domain/enums/DetectorOrders.js';
-
-import { NonPhysicalDetector } from '../../domain/enums/detectorsNames.mjs';
-
 import { RemoteDataProvider } from '../RemoteDataProvider.js';
-const DETECTORS_EXCLUDED_FROM_QC = [NonPhysicalDetector.GLO];
 
 /**
  * Return the physical detectors from a list of detectors
@@ -37,7 +33,17 @@
  * @return {Detector[]} QC detectors
  */
 const getQcDetectorsFromAllDetectors = (allDetectors) => allDetectors
-    .filter(({ type, name }) => QC_DETECTORS.includes(type) && !DETECTORS_EXCLUDED_FROM_QC.includes(name));
+    .filter(({ type }) => QC_DETECTORS.includes(type));
+
+/**
+ * Return the RCT async detectors from a list of detectors
+ *
+ * @param {Detector[]} allDetectors the list of all detectors
+ * @return {Detector[]} RCT async detectors
+ */
+const getRctAsyncDetectorsFromAllDetectors = (allDetectors) => allDetectors.filter(
+    ({ type, name }) => type !== DetectorType.AOT_GLO && name != 'CTP'
+);
 
 /**
  * Service class to fetch detectors from the backend
@@ -71,6 +77,13 @@
                 Success: getQcDetectorsFromAllDetectors,
             }))
             .build();
+
+        this._rctAsync$ = ObservableData.builder()
+            .source(this._items$)
+            .apply((remoteDetectors) => remoteDetectors.apply({
+                Success: getRctAsyncDetectorsFromAllDetectors,
+            }))
+            .build();
     }
 
     /**
@@ -144,6 +157,18 @@
         return this._dataTaking$;
     }
 
+    /**
+     * Return RCT async detectors list observable data
+     *
+     * @return {ObservableData<RemoteData<Detector[], ApiError>>} the observable RCT async detectors list
+     */
+    get rctAsync$() {
+        if (this._isStale()) {
+            this._load();
+        }
+        return this._rctAsync$;
+    }
+
     /**
      * Return physical and QC (meaning physical ones plus e.g. 'GLO') detectors list observable data
      *

lib/public/views/Runs/Overview/RunsWithQcModel.js

@@ -292,11 +292,10 @@
                                 .map(({ id }) => id).join(','),
                             mcReproducibleAsNotBad: this._mcReproducibleAsNotBad.isToggled,
                         }));
-
                         const { data: qcSummary2 } = await getRemoteData(buildUrl('/api/qcFlags/summary', {
                             ...this.qcSummaryScope,
                             detectorIds: detectors
-                                .filter(({ type }) => [DetectorType.AOT_GLO, DetectorType.AOT_EVENT, DetectorType.MUON_GLO].includes(type))
+                                .filter(({ type }) => [DetectorType.QC_ONLY, DetectorType.AOT_GLO, DetectorType.AOT_EVENT, DetectorType.MUON_GLO].includes(type))
                                 .map(({ id }) => id).join(','),
                             filter: {
                                 createdBy: {

lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewModel.js

@@ -21,7 +21,7 @@
 import { SkimmingStage } from '../../../domain/enums/SkimmingStage.js';
 import { jsonFetch } from '../../../utilities/fetch/jsonFetch.js';
 import { RemoteDataSource } from '../../../utilities/fetch/RemoteDataSource.js';
 import { DetectorType } from '../../../domain/enums/DetectorTypes.js';
 import { GaqFilterModel } from '../../../components/Filters/RunsFilter/GaqFilterModel.js';
 import { filterOutLegacyDetectorsForNewerPeriods } from '../../../utilities/filterOutLegacyDetectorsForNewerPeriods.js';
 
@@ -45,12 +45,12 @@
         this._filteringModel.put('gaq', new GaqFilterModel(this._mcReproducibleAsNotBad));
 
         this._setDetectorsObservable(
-            [rctDetectorsProvider.qc$, this._dataPass$],
+            [rctDetectorsProvider.rctAsync$, this._dataPass$],
             ([detectors, dataPass]) => {
                 const filteredDetectors = filterOutLegacyDetectorsForNewerPeriods(detectors, dataPass.name);
 
                 return ALL_CPASS_PRODUCTIONS_REGEX.test(dataPass.name)
-                    ? filteredDetectors.filter(({ name, type }) => type !== DetectorType.AOT_GLO || DETECTOR_NAMES_NOT_IN_CPASSES.includes(name))
+                    ? filteredDetectors.filter(({ name }) => !DETECTOR_NAMES_NOT_IN_CPASSES.includes(name))
                     : filteredDetectors;
             },
         );

lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js

@@ -39,7 +39,7 @@ export class RunsPerLhcPeriodOverviewModel extends FixedPdpBeamTypeRunsOverviewM
             ([detectors, lhcPeriodStatistics]) => {
                 const filteredDetectors = filterOutLegacyDetectorsForNewerPeriods(detectors, lhcPeriodStatistics.lhcPeriod.name);
 
-                return filteredDetectors.filter(({ type }) => [DetectorType.PHYSICAL, DetectorType.MUON_GLO].includes(type));
+                return filteredDetectors.filter(({ type }) => [DetectorType.PHYSICAL, DetectorType.QC_ONLY].includes(type));
             },
         );
         this._lhcPeriodStatistics$.bubbleTo(this);

lib/public/views/Runs/RunsPerSimulationPass/RunsPerSimulationPassOverviewModel.js

@@ -33,7 +33,7 @@ export class RunsPerSimulationPassOverviewModel extends FixedPdpBeamTypeRunsOver
 
         this._simulationPass$.bubbleTo(this);
         this._detectors$ = this._setDetectorsObservable(
-            [rctDetectorsProvider.qc$, this._simulationPass$],
+            [rctDetectorsProvider.rctAsync$, this._simulationPass$],
             ([detectors, simulationPass]) => filterOutLegacyDetectorsForNewerPeriods(detectors, simulationPass.name),
         );
     }