Repository navigation
[STALE: REBASE FROM NEW FORK] test: run client-connect.test.ts in its own process (shard 4/4 batch 8 stall) - #42
Open
vadymhimself wants to merge 1 commit into
Conversation
The transaction fixture bounds a child with a blocking spawnSync timeout; in a shared Bun process after earlier files, shard 4/4 batch 8 stalled to the 120 s batch limit while every file passes alone. Add it to SERIAL_FULL_SUITE_FILES so it runs as a one-file batch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
This PR is based on the superseded 2.65 gateway line. Rebuild the change from |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
clients/client-connect.test.tstoSERIAL_FULL_SUITE_FILESinscripts/test.ts, so the batch runner gives it a fresh Bun process.Why
Test shard 4/4 timed out at the 120 s batch limit in batch 8 on recent release-line PRs. The last passing case is client-connect.test.ts:554; the next one (:577, "transaction fixture stops a child retained after valid output") keeps its child alive on purpose and relies on a blocking
spawnSynctimeout to kill it. WhilespawnSyncblocks, Bun's per-test timeout cannot fire. Every file in the batch passes alone, so the stall needs earlier files' process state; a fresh process removes that. Same quarantine reason as the existing serial entries (see tests/helpers/cold-spawn-warmup.ts:216-224).Containment, not a rewrite: making that fixture async would touch about 30 callers in a size-ratcheted file.
Proof wanted
Shard 4/4 green on two runs in a row.
Eval added/updated: N/A test-runner manifest only, no product behaviour change
🤖 Generated with Claude Code