Repository navigation
Fix the findings of the resource framework review - #148
Merged
Merged
Conversation
A repository or remote list decided "no objects yet" from the rows of the page. A page beyond the last one (deleting the last row of the last page, a bookmarked address, objects removed by someone else) has no rows but the server still reports the real count, so the screen claimed nothing existed. The empty state now follows the count, and an address past the end moves to the last page that has rows by replacing the address.
The create form sent and navigated with the name as typed, while the server stores it without surrounding white space. A name with a trailing space was created but the screen then opened a repository that does not exist, the duplicate check for the distribution missed the stored name, and the default base path was derived from the untrimmed text. The name is trimmed once where it is read, as the remote form already does.
After the same user signs in again, the index of roles on single objects is read again from an empty answer. The hook kept reporting "ready" because the earlier read had succeeded, so every object looked refused for the length of the read and screens showed "no permission" instead of loading. The state is ready only when no read of the index is running.
… is the answer The refusal of a roles list read skipped the who-is-signed-in check for every GET of that address, so a refusal in the roles screen or a role picker on a backend that answers an ended session with 403 never opened the sign-in dialog. The skip is now an explicit opt-in of the one request that wants it, the permission index probe of what an account may read, by a marker header the request policy removes before the request leaves the browser. Every other read of the roles list has its refusal checked again.
A repository or remote named "." or ".." produced a link such as /file/repositories/../ that the browser resolves to the parent route, so the object could not be opened and the link went to another screen. Percent encoding does not help (%2E is resolved as a dot segment too), so the two names are escaped twice: the address keeps one literal segment and the object is reported as not found under that text.
A limit of 0, a negative number or NaN started no worker, so the run resolved at once with an array of holes and never called the job, which callers read as "nothing found". Both bounded runners now throw a RangeError for such a limit.
…arts The bulk spec created its remotes and repositories side by side with Promise.all, so when one create failed the others were still running and an object whose task finished after the clean-up had started stayed on the server as a leftover that inflated the counts of later specs. The creates are now all awaited before the first failure is rethrown. The clean-up of the bulk and sync progress specs also no longer throws a second error that hides the first when the API context could not be opened.
…ecting all Select all followed by Delete or Sync acts on every row shown, and the specs only waited for the rows of the filtered address to load. A filter that did not apply (a renamed parameter, a stale cached list) would have shown the first page of the lab and the spec would have deleted or synced seeded repositories. Each spec now waits until the rows shown are exactly the repositories it made, all under its own prefix, before anything is selected.
The in-application move cut the root off the page's own path at the first "/ui/", which is -1 when the application is served from another root and then pushed a nonsense address, so the failure only showed later as a missing table. The root is now taken from the configured base URL and a page outside it fails at the move.
The scale spec started two waits for the table before the click or the move that asks for the screen and awaited them afterwards. When the click threw, the waits were left without a handler and rejected unhandled when their timeout ran out, adding a second and misleading failure and, in a serial run, sometimes failing the next test. One helper now starts both waits, settles them whatever the trigger does and rethrows the first failure.
…ask id The delete report built every task link with formatPath, which throws for a task address without an id and would have unmounted the dialog or the alert that renders it. Such an address is now shown as the plain word, as the other task links of the application do.
… had DescriptorForm took an onSubmit and documented that Enter sends the form, but no form has a submit button and the forms have several text inputs, so the handler was never reached. A future form with one text input would have sent without the checks that guard the Save button. The prop is gone: Enter is swallowed, and sending is only through the screen's Save button.
With rows ticked that the user may not act on, the bulk toolbar vanished including the count, so the check boxes stayed ticked with no explanation. The count now stays and a short note says that no bulk action may be taken on the selected rows.
The chunks of the other entities drop repeated addresses, the repository one passed them on as given, so a repeated address used up request length and made the read ask for more rows than there are distinct addresses.
The object permission index reads the roles of the signed-in user by their address. A session user without one never had the read started and the hook stayed loading for ever, so a screen waiting on it spun without end. It now reports an error, as the global permission read already does for the same condition.
…, Korean and Chinese
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes found while reviewing the framework screens, the entity layer and the end-to-end support. Each change is its own commit and, where it can be tested, the test came first and failed on the unchanged code.
Application
End-to-end specs
Checks: lint, the unit and integration tests, the build, the bundle budget and the public content guard pass locally. The changed bulk, sync progress and scale specs were run against a test deployment of the previous build.