Repository navigation
Fix three end-to-end checks that did not match the rebuilt lists and forms - #146
Merged
Merged
Conversation
…forms - The editor check of a repository it does not own read the repository name from the first cell of a row, which holds the selection checkbox since the lists were rebuilt; it now reads the name from the row's link. - The refused-save check of the edit form looked for the three sentences in one paragraph; the form shows them as the paragraphs of one inline alert, so the check reads the alert and their order. - The filter timing check pressed Enter in the base path box while the label panel it had just applied was still closing and held the focus; it now waits for the panel to be gone before the next filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three end-to-end checks, written before the repository lists and forms were rebuilt, failed against a real server although the application behaves as intended.
Only test files change. Verified against a test server: the three checks pass, and the filter timing check passes three times in a row together with the list check that runs before it.