Skip to content

Fix three end-to-end checks that did not match the rebuilt lists and forms - #146

Merged
aevnsvi merged 1 commit into
mainfrom
e2e-framework-vm-fixes
Nov 21, 2026
Merged

aevnsvi merged 1 commit into
mainfrom
e2e-framework-vm-fixes

Conversation

@aevnsvi

@aevnsvi aevnsvi commented Nov 21, 2026

Copy link
Copy Markdown

Three end-to-end checks, written before the repository lists and forms were rebuilt, failed against a real server although the application behaves as intended.

  • The editor check of a repository it does not own read the repository name from the first cell of a row. Since the rebuild that cell holds the selection checkbox, so no row matched. The name is now read from the row's link.
  • The refused-save check of the edit form looked for the three sentences in one paragraph. The form shows them as the paragraphs of one inline alert, so the check now reads the alert and the order of the sentences.
  • The filter timing check pressed Enter in the base path box while the label panel it had just applied was still closing and holding the focus, so the key never reached the box. The check now waits for the panel to be gone before the next filter.

Only test files change. Verified against a test server: the three checks pass, and the filter timing check passes three times in a row together with the list check that runs before it.

…forms

- The editor check of a repository it does not own read the repository name
  from the first cell of a row, which holds the selection checkbox since the
  lists were rebuilt; it now reads the name from the row's link.
- The refused-save check of the edit form looked for the three sentences in
  one paragraph; the form shows them as the paragraphs of one inline alert, so
  the check reads the alert and their order.
- The filter timing check pressed Enter in the base path box while the label
  panel it had just applied was still closing and held the focus; it now waits
  for the panel to be gone before the next filter.
@aevnsvi
aevnsvi merged commit 3726f59 into main Nov 21, 2026
6 checks passed
@aevnsvi
aevnsvi deleted the e2e-framework-vm-fixes branch November 21, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant