Added event listener for account creation - #302
Closed
illegalcall wants to merge 3 commits into
Closed
illegalcall wants to merge 3 commits into
illegalcall wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes: +74 -43
Tests: +51 -0
Others: +21 -2
#300
Current takeover integration
Integrated current upstream master, preserving its viem migration and removal of the vulnerable external keystore dependency. The accountCreated success event now fires only after synchronous keystore persistence succeeds; creation/directory/write failures produce a single failure event. The extension subscription is disposed with its context, and error payloads are typed unknown.
Validation: compilation and three isolated account-event regressions pass (success, directory failure, keystore export failure). No real keys, wallet files, or network calls were used. Complete lint remains at 248 errors and two warnings, exactly matching an independently checked current-upstream baseline. Added a compile/unit CI job; hosted results are being inspected. No extension publication or blockchain action was performed.