Repository navigation
fix(dashboard): grow the task field on first paste - #888
Draft
AviationNerd wants to merge 3 commits into
Draft
AviationNerd wants to merge 3 commits into
AviationNerd wants to merge 3 commits into
Conversation
Long pasted prompts could stay at the initial height when browser content sizing did not expand the Task field. The field now grows to its existing maximum and scrolls beyond it. Typing and pasting into existing text keep working. Shared prompts remain expanded until edited.
 [Medium impact] The PR appears safe to merge; both numbered previous findings are addressed. SummaryThe Task field now grows from its current text and adjusts when its width changes.
Reviews (3) · Last reviewed commit: "fix(dashboard): keep task field sizing c..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
The browser keeps the caret at the end after paste, so pressing End did not move it and left scrollTop unchanged. Move to the document start before checking that keyboard navigation scrolls the capped field.
The autosizer recalculates height after edits, so a manual resize handle would advertise a size it immediately resets. Remove the handle and cover width-only changes to verify wrapping is recalculated without changing the prompt.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long pasted prompts could remain at the Task field's initial height when browser content sizing did not expand it. The field now resizes from its controlled value, responds to width changes, and keeps shared prompts expanded. Regular prompts cap at 192px and scroll internally; the manual resize handle is removed because the autosizer owns the height.
The dashboard guide documents the field limit. Component and desktop/phone Playwright coverage exercise typing, paste, scrolling, clearing, shared prompts, width changes, and the resize behavior.
Checks:
make buildpassed after the review follow-up.e2e/task-autosize.spec.tspassed in Playwright's official Docker image, covering desktop and phone viewports in dark mode.make test-e2eattempt could not launch Chromium because the host lackslibglib-2.0.so.0; the targeted spec ran successfully in the official image.This PR was made with the help of Codex.
Opened from Aether run run-cs18cdjb7c