Repository navigation
fix(dashboard): make agent sign-in terminals usable - #887
AviationNerd wants to merge 4 commits into
Conversation
Opening agent setup ran its login command before the user chose to run it, and forced the terminal back to main after every tab change. Leave the shell available for typing and provide an explicit login or install action. Keep new tabs selected, prevent alt-click cursor moves into output, and expose terminal sizing controls on desktop.
|
Greptile CLI attempt on head 88bc067: The PR bot review and finding triage remain pending. Separate Opus review is blocked because Claude subsessions are off on the available accounts. An additional independent Codex code review is queued; it does not replace the Opus merge gate. |
A live terminal may hold pending shell input or a foreground program. Copy the setup command for the user to paste and review at a shell prompt, so the action cannot execute combined input or answer a prompt.
1cdbaaa to
4d2bef7
Compare
|
@greptileai review |
|
Independent reviews of final head b6c2bb5:
These reviews do not replace the required separate Opus review. Claude subsessions remain disabled on available accounts. Greptile bot review and CI are pending; this PR remains a draft. |
[Medium impact] No blocking code issues remain in this review. SummaryAgent setup leaves terminal input to the user and offers explicit command-copy buttons.
Both previous findings are addressed. No new actionable issues were found. Reviews (2) · Last reviewed commit: "fix(dashboard): select setup commands wh..." · Reviewed by Greptile |
|
Both Greptile findings are fixed and their threads resolved in 9ba0123: manual selection fallback uses the displayed command element, and regression tests cover exact login/install clipboard payloads, copy-only terminal props and denied clipboard selection. Typecheck, 104 focused tests, production build and public audit passed. Final incremental independent code review requested; current-head CI and bot re-review pending. Final-head CLI attempt: Required separate Opus review is still blocked by disabled Claude subsessions. Linear access and real server/vendor sign-in verification remain unresolved. |
Agent setup previously ran the login command on opening and forced new terminal tabs back to main. Leave the shell ready for typing and show Copy login/install command so the user can paste, review and run it at a shell prompt. Preserve newly selected tabs, disable Alt-click cursor movement into output, and expose expand/shrink controls with a visible resize grip. If clipboard access fails, select the displayed command for manual copying.
Recovered from unpushed commit 68a0cd48a in Aether run run-kav79xx0qd.
Validation on final head 9ba0123:
greptile: command not found.make fmt-checkreports pre-existing formatting in unchangedinternal/runtime/docker_browser.go. The previous session's full dashboard suite had two unchanged timeouts whose files passed focused patched/baseline reruns.libglib-2.0.so.0is missing. Real Docker/server/vendor sign-in end-to-end verification remains incomplete.Remaining work: required separate Opus review (Claude subsessions are disabled), Linear tickets (integration not connected), and real sign-in verification. The old session has finished and its private
/tmpticket draft was not recovered.This PR was made with the help of Codex.
Opened from Aether run run-78tj79mcgk