Skip to content

fix(dashboard): make agent sign-in terminals usable - #887

Draft
AviationNerd wants to merge 4 commits into
mainfrom
aether/run-continue-the-agent-sign-in-termi-78tj79mcgk
Draft

AviationNerd wants to merge 4 commits into
mainfrom
aether/run-continue-the-agent-sign-in-termi-78tj79mcgk

Conversation

@AviationNerd

@AviationNerd AviationNerd commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Agent setup previously ran the login command on opening and forced new terminal tabs back to main. Leave the shell ready for typing and show Copy login/install command so the user can paste, review and run it at a shell prompt. Preserve newly selected tabs, disable Alt-click cursor movement into output, and expose expand/shrink controls with a visible resize grip. If clipboard access fails, select the displayed command for manual copying.

Recovered from unpushed commit 68a0cd48a in Aether run run-kav79xx0qd.

Validation on final head 9ba0123:

  • Typecheck, 104 focused tests, production build and public audit passed. Current-head CI gate is green.
  • Independent Codex code review found no remaining blockers, including the final clipboard fallback change.
  • Independent design review rendered real frontend components with mock transport at desktop and phone widths. No remaining change-specific blocker; retained comparison evidence evid-6d2pb46a45. Application dark was forced, but the browser broker could not force OS colorScheme. Fine-pointer drag, soft keyboard, screen reader and real authentication were not verified. Six-tab crowding at 320px also occurs on baseline and is a follow-up.
  • Greptile reviewed the final head at 5/5, confirmed both findings addressed, and found no new actionable issues. Both threads are resolved. The CLI attempt failed with greptile: command not found.
  • make fmt-check reports pre-existing formatting in unchanged internal/runtime/docker_browser.go. The previous session's full dashboard suite had two unchanged timeouts whose files passed focused patched/baseline reruns.
  • A Docker-backed Playwright attempt passed one API-only scenario; four browser scenarios could not launch Chromium because libglib-2.0.so.0 is missing. Real Docker/server/vendor sign-in end-to-end verification remains incomplete.

Remaining work: required separate Opus review (Claude subsessions are disabled), Linear tickets (integration not connected), and real sign-in verification. The old session has finished and its private /tmp ticket draft was not recovered.

This PR was made with the help of Codex.

Opened from Aether run run-78tj79mcgk

Opening agent setup ran its login command before the user chose to run
it, and forced the terminal back to main after every tab change.

Leave the shell available for typing and provide an explicit login or
install action. Keep new tabs selected, prevent alt-click cursor moves
into output, and expose terminal sizing controls on desktop.
@AviationNerd

Copy link
Copy Markdown
Collaborator Author

Greptile CLI attempt on head 88bc067:

$ greptile review --apex --agent
/bin/bash: line 5: greptile: command not found

The PR bot review and finding triage remain pending. Separate Opus review is blocked because Claude subsessions are off on the available accounts. An additional independent Codex code review is queued; it does not replace the Opus merge gate.

A live terminal may hold pending shell input or a foreground program.
Copy the setup command for the user to paste and review at a shell
prompt, so the action cannot execute combined input or answer a prompt.
@AviationNerd
AviationNerd force-pushed the aether/run-continue-the-agent-sign-in-termi-78tj79mcgk branch from 1cdbaaa to 4d2bef7 Compare November 13, 2026 00:54
@AviationNerd

Copy link
Copy Markdown
Collaborator Author

@greptileai review

@AviationNerd

AviationNerd commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator Author

Independent reviews of final head b6c2bb5:

  • Code review (separate Codex session run-hzh508ct6x): no remaining blockers. The P2 finding that Run could append to pending shell input or submit text to a foreground CLI was resolved by the Copy action. Final source comparison was against d705702; reviewer did not rerun tests or browser checks.
  • Design review (separate Codex session run-r426mzb3w8): rendered current Copy flow at narrow and desktop widths; no additional revised sign-in layout blocker. The old Run action clipped at 320px, resolved by moving the Copy action above the dock. Six-tab crowding at 320px was reproduced on baseline d705702 in the same fixture and is a pre-existing follow-up, not a blocker introduced here. Retained comparison evidence: evid-6d2pb46a45 (baseline, final six-tab layout, final 320px Copy flow, desktop). Fixture used real frontend components with mock transport and forced application dark; browser OS colorScheme, fine-pointer drag, clipboard, real authentication and screen-reader behavior were not verified.

These reviews do not replace the required separate Opus review. Claude subsessions remain disabled on available accounts. Greptile bot review and CI are pending; this PR remains a draft.

@greptile-apps

greptile-apps Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5 Tier: apex

[Medium impact] No blocking code issues remain in this review.

Summary

Agent setup leaves terminal input to the user and offers explicit command-copy buttons.

  • Agent setup leaves commands for people to paste into the shell.
  • The Environment terminal can be resized with a grip or button.
  • Alt-click no longer moves the cursor in terminal views.
  • Opening setup keeps the terminal tab the person selected.

Both previous findings are addressed. No new actionable issues were found.

Reviews (2) · Last reviewed commit: "fix(dashboard): select setup commands wh..." · Reviewed by Greptile

@AviationNerd

Copy link
Copy Markdown
Collaborator Author

Both Greptile findings are fixed and their threads resolved in 9ba0123: manual selection fallback uses the displayed command element, and regression tests cover exact login/install clipboard payloads, copy-only terminal props and denied clipboard selection. Typecheck, 104 focused tests, production build and public audit passed. Final incremental independent code review requested; current-head CI and bot re-review pending.

Final-head CLI attempt:

$ greptile review --apex --agent
/bin/bash: line 1: greptile: command not found

Required separate Opus review is still blocked by disabled Claude subsessions. Linear access and real server/vendor sign-in verification remain unresolved.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant