perf(proxy/upstream_connection): setup configuration in init phase - #1602
Open
tkan145 wants to merge 1 commit into
Open
perf(proxy/upstream_connection): setup configuration in init phase#1602tkan145 wants to merge 1 commit into
tkan145 wants to merge 1 commit into
Conversation
Previously, the configuration for these two policies was set up in the export() phase. This phase only runs once, when the PolicyChain is built at configuration load time. In PR 3scale#1485, we moved those parts to the rewrite phase and caused a small allocation per request. This PR eliminates that by moving the configuration construction to the init phase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Previously, the configuration for these two policies was set up in the export() phase. This phase only runs once, when the PolicyChain is built at configuration load time.
In PR #1485, we moved those parts to the rewrite phase and caused a small allocation per request. This PR eliminates that by moving the configuration construction to the init phase.