Conversation
- remove unused InfluxDB, c3p0, mchange, and HikariCP verification entries - align the null-address GetAccount test with the actual empty response - rename the test to reflect its expected behavior
|
Hi @3for, thanks for the cleanup — the Two things I wanted to ask while reviewing: 1. Why delete these tests instead of fixing them? For example 2. Overlap and coordination We have opened a dedicated PR that fixes the underlying resource/state-leak issues themselves, test-only: warku123#12. It covers, among others: Since roughly a dozen files overlap between our two PRs (e.g. |
- Remove unused Shadow plugin, Commons Math, AspectJ tools and JCIP annotations - Drop redundant common-protos, bcprov and Error Prone dependency declarations - Clean up stale checksum entries in Gradle dependency verification metadata
- Correct HTTP methods, request fields and Wallet mock responses - Verify RPC errors, validation messages and transaction processing - Replace ineffective assertions and fix serialization, collection and storage fixtures - Restore metrics assertions and initialize contract mappings explicitly
What does this PR do?
Why are these changes required?
Several tests had drifted from current implementation behavior or relied on broad exception handling, tautological assertions, and execution-only checks that could pass without validating meaningful outcomes.
Obsolete test sources and stale dependency verification entries also added maintenance noise. These changes make the test suite more accurate, deterministic, and effective at detecting regressions.
This PR has been tested by:
git diff --check.Follow up
No follow-up changes are currently required. CI will provide final validation across supported environments.