diff --git a/dataset/src/main/scala/frameless/TypedColumn.scala b/dataset/src/main/scala/frameless/TypedColumn.scala index 4140cabe..4c56a3f8 100644 --- a/dataset/src/main/scala/frameless/TypedColumn.scala +++ b/dataset/src/main/scala/frameless/TypedColumn.scala @@ -605,6 +605,18 @@ abstract class AbstractTypedColumn[T, U]( ): SortedTypedColumn[T, U] = new SortedTypedColumn[T, U](untyped.asc) + def asc_nulls_first(implicit catalystOrdered: CatalystOrdered[U]): SortedTypedColumn[T, U] = + new SortedTypedColumn[T, U](untyped.asc_nulls_first) + + def asc_nulls_last(implicit catalystOrdered: CatalystOrdered[U]): SortedTypedColumn[T, U] = + new SortedTypedColumn[T, U](untyped.asc_nulls_last) + + def desc_nulls_first(implicit catalystOrdered: CatalystOrdered[U]): SortedTypedColumn[T, U] = + new SortedTypedColumn[T, U](untyped.desc_nulls_first) + + def desc_nulls_last(implicit catalystOrdered: CatalystOrdered[U]): SortedTypedColumn[T, U] = + new SortedTypedColumn[T, U](untyped.desc_nulls_last) + /** * Bitwise AND this expression and another expression. * {{{ diff --git a/dataset/src/test/scala/frameless/OrderByTests.scala b/dataset/src/test/scala/frameless/OrderByTests.scala index 20137819..d6ba6fbb 100644 --- a/dataset/src/test/scala/frameless/OrderByTests.scala +++ b/dataset/src/test/scala/frameless/OrderByTests.scala @@ -10,6 +10,10 @@ class OrderByTests extends TypedDatasetSuite with Matchers { def sortings[A: CatalystOrdered, T]: Seq[(TypedColumn[T, A] => SortedTypedColumn[T, A], Column => Column)] = Seq( (_.desc, _.desc), (_.asc, _.asc), + (_.desc_nulls_first, _.desc_nulls_first), + (_.desc_nulls_last, _.desc_nulls_last), + (_.asc_nulls_first, _.asc_nulls_first), + (_.asc_nulls_last, _.asc_nulls_last), (t => t, t => t) // default ascending )