Skip to content

NGRX actions update? #100

Description

@MaciejWWojcik

Hey, I was wondering if it makes sense to update this item on the checklist:
https://angular-checklist.io/default/checklist/ngrx/iglD3

It's about defining Actions as classes, like that:

  export enum AppActionTypes {
    APP_PAGE_LOAD_USERS = '[App Page] Load Users'
  }
  
  export class AppPageLoadUsers implements Action {
    readonly type = AppActionTypes.APP_PAGE_LOAD_USERS;
  }

However, based on the newest ngrx docs (https://ngrx.io/guide/store/actions), it maybe should look more like this:

  export const loadUsers = createAction('[App Page] Load Users');

What do you think about that?
I'm happy to update this content item, but I'm not sure if we want that, and if so, how many changes do we think it needs?
I'm not sure if "note + resources" makes much sense when using a new ngrx wrapper for actions.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions