Skip to content

Possible incompleteness #268

Description

@YichiZhang0613

As you mentioned in documentation, I think the index should be checked whether it is out of bounds before directly used as polygon.points[index].
turtle-master/src/renderer_server/renderer/display_list.rs

/// Panics if the given handle does not refer to a polygon primitive or if the given index is
    /// out of bounds.
    pub fn polygon_update(&mut self, handle: PrimHandle, index: usize, point: Point) {
        let prim = self.items.get_mut(&handle).expect("bug: invalid handle");
        let polygon = prim.as_polygon_mut()
            .expect("bug: attempt to update a point in a draw primitive that was not a polygon");

        // This will panic if the index is out of bounds
        polygon.points[index] = point;
    }

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions