Makefile:134 (branch scylla-3.x), in the LTS-PRIOR arm of resolve-scylla-version, passes the
scylladb/scylla-enterprise fallback filter with a single $:
SCYLLA_VERSION_RESOLVED=$$(get-version --source dockerhub-imagetag --repo scylladb/scylla-enterprise -filters "^[0-9]{4}$.^[0-9]+$.^[0-9]+$ and LAST-1.1.LAST" | tr -d '\"')Make expands $. to the empty string (. is an undefined single-character variable), so
get-version receives "^[0-9]{4}^[0-9]+^[0-9]+ and LAST-1.1.LAST" — a corrupted regex. The
fallback is therefore silently inert.
Every sibling line in the same target escapes it correctly as $$, and scylla-4.x has the
correct form at the equivalent line. Fix is $ → $$ in that one string.
Reachable today only when the primary scylladb/scylla lookup for LTS-PRIOR returns nothing.
Note this line sits inside resolve-scylla-version, the target rewritten by #1044, so rebase on
that.
Found while auditing version resolution for DRIVER-925.
Makefile:134(branchscylla-3.x), in theLTS-PRIORarm ofresolve-scylla-version, passes thescylladb/scylla-enterprisefallback filter with a single$:Make expands
$.to the empty string (.is an undefined single-character variable), soget-versionreceives"^[0-9]{4}^[0-9]+^[0-9]+ and LAST-1.1.LAST"— a corrupted regex. Thefallback is therefore silently inert.
Every sibling line in the same target escapes it correctly as
$$, andscylla-4.xhas thecorrect form at the equivalent line. Fix is
$→$$in that one string.Reachable today only when the primary
scylladb/scyllalookup forLTS-PRIORreturns nothing.Note this line sits inside
resolve-scylla-version, the target rewritten by #1044, so rebase onthat.
Found while auditing version resolution for DRIVER-925.