From 97680a529316fee83398120388d78b163f12bb6b Mon Sep 17 00:00:00 2001 From: Christophe Dervieux Date: Tue, 22 Sep 2026 14:03:43 +0200 Subject: [PATCH] Scope test-smokes-built.yml's workflow_run trigger to main With no branches filter, any completed create-release.yml run - including manual workflow_dispatch from a non-main branch, a common pattern during packaging/signing work (22 such dispatches in the last 300 runs) - fans out the full built-version smoke/playwright/feature-format-matrix suite across three OSes. Release branches (v1.9, v1.10) are excluded from the filter since they predate the binary-mode test harness added in #14706 and would fail on a missing harness rather than a real defect. The manual escape hatch (dispatching this workflow with source=nightly and an explicit run-id) is unaffected. --- .github/workflows/test-smokes-built.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-smokes-built.yml b/.github/workflows/test-smokes-built.yml index bf409400e81..0e9d7c397a6 100644 --- a/.github/workflows/test-smokes-built.yml +++ b/.github/workflows/test-smokes-built.yml @@ -1,10 +1,13 @@ name: Smoke Tests (Built Version) run-name: "Smoke Tests (Built Version) - ${{ (github.event_name == 'workflow_run' && 'nightly') || github.event.inputs.source || 'build' }}" on: - # Test scheduled and manually dispatched create-release builds. + # Test scheduled and manually dispatched create-release builds from main. + # Branch dispatches must not fan out; to test one, dispatch this workflow with + # source=nightly and that run's id. workflow_run: workflows: ["Build Installers"] types: [completed] + branches: [main] workflow_dispatch: inputs: source: