Skip to content

GitHub CodeQL reports for overly permissive file permissions #3267

Description

@tibersept

CodeQL has a Python rule with ID py/overly-permissive-file which flags several chmod/open calls in the node-gyp Python code. I would like to confirm that these operations are intentionally more permissive and safe to suppress.

Flagged locations

File Line Code CodeQL concern
gyp/pylib/gyp/common.py 561 os.chmod(tool_path, 0o755) World readable
gyp/pylib/gyp/flock_tool.py 43 os.open(lockfile, ..., 0o666) World readable/writable
gyp/pylib/gyp/mac_tool.py 250 os.open(lockfile, ..., 0o666) World readable/writable
  • 0o755 on common.py:561 is set because you are unsure whether all build processes are run with the same user
  • 0o666 on lock files in flock_tool.py and mac_tool.py is intentional, with umask expected to restrict actual permissions

Could you confirm these permissions are intentional and by design?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions