Skip to content

Enter/return is borked on Chrome/Mac OS. #59

Description

@hellige

Tested in goforth: http://0x10co.de/hiwhx

Goforth expects enter to send the keycode spec'ed in the keyboard spec. 0x10co.de does generate that keycode, but then it also generates an extra 0x13. It looks like the key is being triggered through both the keydown event and the keypress event. The keypress event doesn't check keyMap, which explains why it's not being converted. But either way, it's extra.

Changing line 413 of ui.js to:
if(e.which >= 37 && e.which <= 40 || e.which === 8 || e.which === 13) e.preventDefault();
fixes it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions