|
| 1 | +"""High-level operands must not become Git options.""" |
| 2 | + |
| 3 | +from unittest import mock |
| 4 | + |
| 5 | +import pytest |
| 6 | + |
| 7 | +from git import Actor, Git, GitCommandError, Head, Remote, RemoteReference, Repo, TagReference |
| 8 | +from git.exc import UnsafeOptionError |
| 9 | + |
| 10 | + |
| 11 | +@pytest.mark.parametrize("allow_unsafe_options", [False, True]) |
| 12 | +@pytest.mark.parametrize( |
| 13 | + "refspec", |
| 14 | + ["--upload-pack=helper", ["--upl=helper"], ["main", "--dry-run"], "-uhelper", "--arg value", "--"], |
| 15 | +) |
| 16 | +def test_pull_rejects_option_shaped_refspec(tmp_path, refspec, allow_unsafe_options): |
| 17 | + repo = Repo.init(tmp_path) |
| 18 | + remote = Remote(repo, "origin") |
| 19 | + with mock.patch.object(Git, "_call_process", side_effect=AssertionError("Git must not run")) as run: |
| 20 | + with pytest.raises(UnsafeOptionError): |
| 21 | + remote.pull(refspec, allow_unsafe_options=allow_unsafe_options) |
| 22 | + run.assert_not_called() |
| 23 | + |
| 24 | + |
| 25 | +def test_pull_rejects_option_shaped_remote(tmp_path): |
| 26 | + repo = Repo.init(tmp_path) |
| 27 | + remote = Remote(repo, "--upload-pack=helper") |
| 28 | + with mock.patch.object(Git, "_call_process", side_effect=AssertionError("Git must not run")) as run: |
| 29 | + with pytest.raises(UnsafeOptionError): |
| 30 | + remote.pull("main") |
| 31 | + run.assert_not_called() |
| 32 | + |
| 33 | + |
| 34 | +def test_pull_preserves_operand_and_explicit_option_values(tmp_path): |
| 35 | + repo = Repo.init(tmp_path) |
| 36 | + remote = Remote(repo, "origin") |
| 37 | + with mock.patch.object(Git, "_call_process") as run, mock.patch.object( |
| 38 | + Remote, "_get_fetch_info_from_stderr", return_value=[] |
| 39 | + ): |
| 40 | + remote.pull("refs/heads/topic", upload_pack="helper with spaces", allow_unsafe_options=True) |
| 41 | + assert run.call_args[0] == ("pull", "--", remote, ["refs/heads/topic"]) |
| 42 | + assert run.call_args[1]["upload_pack"] == "helper with spaces" |
| 43 | + |
| 44 | + |
| 45 | +def test_delete_head_cannot_override_force(tmp_path): |
| 46 | + repo = Repo.init(tmp_path) |
| 47 | + actor = Actor("Test", "test@example.com") |
| 48 | + initial = repo.index.commit("initial", author=actor, committer=actor) |
| 49 | + branch = repo.create_head("unmerged", initial) |
| 50 | + branch.commit = repo.index.commit("unmerged", head=False, author=actor, committer=actor) |
| 51 | + with pytest.raises(GitCommandError): |
| 52 | + repo.delete_head("--force", branch, force=False) |
| 53 | + assert branch.is_valid() |
| 54 | + repo.delete_head(branch, force=True) |
| 55 | + assert not branch.is_valid() |
| 56 | + |
| 57 | + |
| 58 | +def test_rename_head_cannot_select_current_branch(tmp_path): |
| 59 | + repo = Repo.init(tmp_path) |
| 60 | + actor = Actor("Test", "test@example.com") |
| 61 | + repo.index.commit("initial", author=actor, committer=actor) |
| 62 | + original = repo.active_branch.name |
| 63 | + with pytest.raises(GitCommandError): |
| 64 | + Head(repo, "refs/heads/--force").rename("renamed") |
| 65 | + assert repo.active_branch.name == original |
| 66 | + |
| 67 | + |
| 68 | +def test_tag_operands_follow_option_terminator(tmp_path): |
| 69 | + repo = Repo.init(tmp_path) |
| 70 | + with mock.patch.object(Git, "_call_process") as run: |
| 71 | + TagReference.create(repo, "topic", "HEAD") |
| 72 | + assert run.call_args[0] == ("tag", "--", "topic", "HEAD") |
| 73 | + TagReference.delete(repo, "--list") |
| 74 | + assert run.call_args[0] == ("tag", "-d", "--", "--list") |
| 75 | + |
| 76 | + |
| 77 | +def test_remote_ref_delete_preserves_operand(tmp_path): |
| 78 | + repo = Repo.init(tmp_path) |
| 79 | + ref = RemoteReference(repo, "refs/remotes/--force") |
| 80 | + with mock.patch.object(Git, "_call_process") as run: |
| 81 | + RemoteReference.delete(repo, ref) |
| 82 | + assert run.call_args[0] == ("branch", "-d", "-r", "--", ref) |
| 83 | + |
| 84 | + |
| 85 | +def test_move_treats_option_shaped_source_as_filename(tmp_path): |
| 86 | + repo = Repo.init(tmp_path) |
| 87 | + (tmp_path / "--force").write_text("literal source") |
| 88 | + repo.index.add(["--force"]) |
| 89 | + assert repo.index.move(["--force", "destination"]) == [("--force", "destination")] |
| 90 | + assert (tmp_path / "destination").read_text() == "literal source" |
| 91 | + assert not (tmp_path / "--force").exists() |
| 92 | + |
| 93 | + |
| 94 | +def test_move_cannot_override_overwrite_protection(tmp_path): |
| 95 | + repo = Repo.init(tmp_path) |
| 96 | + for name in ("--force", "source", "destination"): |
| 97 | + (tmp_path / name).write_text(name) |
| 98 | + repo.index.add(["--force", "source", "destination"]) |
| 99 | + with pytest.raises(GitCommandError): |
| 100 | + repo.index.move(["--force", "source", "destination"]) |
| 101 | + assert (tmp_path / "source").read_text() == "source" |
| 102 | + assert (tmp_path / "destination").read_text() == "destination" |
| 103 | + repo.index.move(["source", "destination"], force=True) |
| 104 | + assert (tmp_path / "destination").read_text() == "source" |
| 105 | + |
| 106 | + |
| 107 | +def test_ignored_treats_option_shaped_path_as_filename(tmp_path): |
| 108 | + repo = Repo.init(tmp_path) |
| 109 | + (tmp_path / ".gitignore").write_text("--verbose\n--arg value\n") |
| 110 | + assert repo.ignored("--verbose", "--arg value") == ["--verbose", "--arg value"] |
| 111 | + |
| 112 | + |
| 113 | +def test_move_cannot_override_dry_run(tmp_path): |
| 114 | + repo = Repo.init(tmp_path) |
| 115 | + (tmp_path / "source").write_text("source") |
| 116 | + repo.index.add(["source"]) |
| 117 | + with pytest.raises(GitCommandError): |
| 118 | + repo.index.move(["--no-dry-run", "source", "destination"], dry_run=True) |
| 119 | + assert (tmp_path / "source").read_text() == "source" |
| 120 | + assert not (tmp_path / "destination").exists() |
| 121 | + |
| 122 | + |
| 123 | +@pytest.mark.parametrize("name", ["--prune", "--all", "--upload-pack=helper"]) |
| 124 | +def test_remote_update_rejects_option_shaped_name(tmp_path, name): |
| 125 | + repo = Repo.init(tmp_path) |
| 126 | + with mock.patch.object(Git, "_call_process", side_effect=AssertionError("Git must not run")) as run: |
| 127 | + with pytest.raises(UnsafeOptionError): |
| 128 | + Remote(repo, name).update() |
| 129 | + run.assert_not_called() |
0 commit comments